modify gitignore and kafka-debug Dockerfile#53
Open
tfnick wants to merge 2 commits into
Open
Conversation
|
wenxue.liu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Thanks for the PR @tfnick . The OS-specific files in the .gitignore aren't repository specific; could you move them to your local .gitignore on your machine? Other than that, LGTM. We'll need to you agree to the CLA (link below) before we can accept your contribution. Thank you, |
sambott
requested changes
Apr 20, 2018
sambott
left a comment
sambott
left a comment
Contributor
There was a problem hiding this comment.
The OS-specific files in the .gitignore aren't repository specific; could you move them to your local .gitignore on your machine?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because of kafka 0.10.1.0' s tgz download link is invalid, fix it.