feat: expose adding trust anchor / intermediate certificates on the FFI pki env#2150
Open
typfel wants to merge 4 commits into
Open
feat: expose adding trust anchor / intermediate certificates on the FFI pki env#2150typfel wants to merge 4 commits into
typfel wants to merge 4 commits into
Conversation
coriolinus
reviewed
May 19, 2026
Contributor
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
IMO we need at least some documentation about proper usage before approving this.
| /// Add a DER-encoded certificate as a trust anchor. | ||
| pub async fn add_trust_anchor(&self, name: &str, cert_der: &[u8]) -> CoreCryptoResult<()> { | ||
| let cert = x509_cert::Certificate::from_der(cert_der).map_err(CoreCryptoError::generic())?; | ||
| self.0.add_trust_anchor(name, cert).await?; |
Contributor
There was a problem hiding this comment.
This is dangerous at the moment; until we do a database migration (which we wanted to postpone until after CC 10) any new trust anchor will silently overwrite the previous trust anchor. So at the very least I'd like to see some docs to that effect if we make this function public.
istankovic
reviewed
May 19, 2026
| ppJsiJ+R0Mj4ato4FPg90nm0OtACIQCAIjV4mlXh8Gp2RRSlwuA894+NhyztLPU+vErHy/0I | ||
| uA== | ||
| `.replace(/\s/g, ""); | ||
|
|
Contributor
|
47af192 is missing a commit type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Expose adding trust anchor / intermediate certificates on the FFI pki env
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.