Skip to content

feat(drive): Make files available offline (WPB-23968)#4811

Merged
ohassine merged 79 commits into
developfrom
Make-files-available-offline
Jun 4, 2026
Merged

feat(drive): Make files available offline (WPB-23968)#4811
ohassine merged 79 commits into
developfrom
Make-files-available-offline

Conversation

@ohassine

@ohassine ohassine commented May 12, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-23968


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Allow users to make files available offline, so they can browse them later when they don't have Internet

  • Added two new actions to "Make file offline" and "remove offline access"
  • Show download indication for offline files
  • Removing offline access of a file will delete the file from device, so user needs to download it again
  • Files are stored in app specific external storage, so they are not user accessible from other apps(like Files) and will be deleted after app uninstall.

Showing the list of offline files will be handled in next PR

+Changes from:
Display offline files (WPB-23968) (#4822)

Screenshot 2026-05-12 at 13 28 42
screen-20260512-132241-1778584935958.mp4

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine added 30 commits April 23, 2026 18:56
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
…le-offline

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileActionsMenu.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileLocalPathCache.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesWithSlideInTransitionScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/OpenFileDownloadController.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/NodeBottomSheetAction.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/OpenLoadState.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/util/FileHelper.kt
#	features/cells/src/main/res/values/strings.xml
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellFileActionsMenuTest.kt
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/OpenFileDownloadControllerTest.kt
#	kalium
@github-actions

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
122f2bd1c5e31459d5d090aeeee0a808064a5ef1 227ebac8faac06c08139cfdf5062f26c38974bf9

Is this intentional?

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
c86db860bb35c8ba3011ce35852ae36fa6d1e21f 129cd34a74cbb44d3931fbe3a2a656cebdf816a2

Is this intentional?

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
c86db860bb35c8ba3011ce35852ae36fa6d1e21f 19aa40b63fb430b87ac217419ab8cce8f309df9b

Is this intentional?

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
c86db860bb35c8ba3011ce35852ae36fa6d1e21f 19aa40b63fb430b87ac217419ab8cce8f309df9b

Is this intentional?

@ohassine ohassine enabled auto-merge June 4, 2026 10:42
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
c86db860bb35c8ba3011ce35852ae36fa6d1e21f e996a3aced8de5a826c8dc7f071fccf5d35f6ef2

Is this intentional?

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@ohassine ohassine added this pull request to the merge queue Jun 4, 2026
Merged via the queue into develop with commit ed4336d Jun 4, 2026
19 of 20 checks passed
@ohassine ohassine deleted the Make-files-available-offline branch June 4, 2026 11:14
MohamadJaara pushed a commit that referenced this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants