Skip to content

feat: Show offline indicator for files in conversation (WPB-23968) #4846

Merged
ohassine merged 111 commits into
developfrom
show-offline-indicator-for-files-in-conversation
Jun 5, 2026
Merged

feat: Show offline indicator for files in conversation (WPB-23968) #4846
ohassine merged 111 commits into
developfrom
show-offline-indicator-for-files-in-conversation

Conversation

@ohassine

@ohassine ohassine commented May 20, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-23968


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Show offline indicator for files available offline in conversation screen

Screenshot_20260518_161250

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine added 30 commits April 23, 2026 18:56
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
…le-offline

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileActionsMenu.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileLocalPathCache.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesWithSlideInTransitionScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/OpenFileDownloadController.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/NodeBottomSheetAction.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/OpenLoadState.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/util/FileHelper.kt
#	features/cells/src/main/res/values/strings.xml
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellFileActionsMenuTest.kt
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/OpenFileDownloadControllerTest.kt
#	kalium
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

ohassine added 2 commits June 4, 2026 12:23
…ator-for-files-in-conversation

# Conflicts:
#	app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsView.kt
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	kalium
@pull-request-size pull-request-size Bot added size/S and removed size/XL labels Jun 4, 2026
@ohassine ohassine requested a review from sbakhtiarov June 4, 2026 14:21
@MohamadJaara MohamadJaara changed the title feat: Show offline indicator for files in conversation (WPB-23968) feat: Show offline indicator for files in conversation (WPB-23968) Jun 5, 2026
@ohassine ohassine enabled auto-merge June 5, 2026 10:08
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (691dade) to head (9a508a0).

Files with missing lines Patch % Lines
...getypes/multipart/MultipartAttachmentsViewModel.kt 77.27% 5 Missing ⚠️
.../conversations/ConversationCoreViewModelFactory.kt 0.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (65.38%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4846      +/-   ##
===========================================
+ Coverage    49.30%   49.32%   +0.01%     
===========================================
  Files          646      646              
  Lines        22874    22891      +17     
  Branches      3503     3503              
===========================================
+ Hits         11279    11291      +12     
- Misses       10549    10553       +4     
- Partials      1046     1047       +1     
Files with missing lines Coverage Δ
...me/conversations/ConversationCoreViewModelGraph.kt 0.00% <ø> (ø)
...messagetypes/multipart/MultipartAttachmentsView.kt 0.00% <ø> (ø)
.../conversations/ConversationCoreViewModelFactory.kt 0.00% <0.00%> (ø)
...getypes/multipart/MultipartAttachmentsViewModel.kt 57.14% <77.27%> (+4.39%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691dade...9a508a0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Jun 5, 2026

Copy link
Copy Markdown

@ohassine ohassine added this pull request to the merge queue Jun 5, 2026
Merged via the queue into develop with commit 835d75e Jun 5, 2026
21 checks passed
@ohassine ohassine deleted the show-offline-indicator-for-files-in-conversation branch June 5, 2026 14:14
ohassine added a commit that referenced this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants