-
Notifications
You must be signed in to change notification settings - Fork 46
feat: Show offline indicator for files in conversation (WPB-23968) #4846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ohassine
merged 111 commits into
develop
from
show-offline-indicator-for-files-in-conversation
Jun 5, 2026
Merged
Changes from all commits
Commits
Show all changes
111 commits
Select commit
Hold shift + click to select a range
3b353bd
feat: new loading behavior
ohassine 6704b01
Merge remote-tracking branch 'origin/develop' into new-loading-behavior
ohassine 5d97f06
Merge remote-tracking branch 'origin/develop' into new-loading-behavior
ohassine 43c0418
feat: remove download to external storage option
ohassine 9ea06e7
feat: cleanup
ohassine fa81683
feat: detekt
ohassine dcf676f
Merge remote-tracking branch 'origin/develop' into new-loading-behavior
ohassine ca33415
Merge remote-tracking branch 'origin/develop' into new-loading-behavior
ohassine ff7f3b5
feat: cleanup
ohassine 8d57c00
feat: cleanup
ohassine 5296036
feat: cleanup
ohassine add26ee
fix: cleanup
ohassine 942a6e2
fix: cleanup
ohassine a9e6d8c
feat: refactor
ohassine 2bb96f2
feat: unit test
ohassine d403848
Merge branch 'develop' into new-loading-behavior
ohassine 771b73d
feat: detekt
ohassine 3f458b1
Merge remote-tracking branch 'origin/new-loading-behavior' into new-l…
ohassine 784c3d3
feat: detekt
ohassine 24a0eea
Merge branch 'develop' into new-loading-behavior
ohassine f8a0d11
Merge branch 'develop' into new-loading-behavior
ohassine d76da05
chore: test
ohassine 1a25574
Merge branch 'develop' into new-loading-behavior
ohassine defa808
feat(drive): Make files available offline
ohassine 57eb842
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine ed03ad9
feat(drive): Make files available offline
ohassine e45ce22
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine e629614
chore: cleanup
ohassine a6852d9
chore: cleanup
ohassine 5db198b
chore: detekt
ohassine 2a1bd5f
chore: detekt
ohassine fcd8bb1
chore: cleanup
ohassine e7589b7
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine 66771b7
feat: modifiedAt from String to Long
ohassine 6576a50
feat: cleanup
ohassine 6343f92
Merge branch 'develop' into Make-files-available-offline
ohassine c4c8be5
feat: cleanup
ohassine 22fd15f
feat: kalium reference
ohassine d050772
feat: cleanup
ohassine d2d0998
feat: test
ohassine b9ff6a8
Merge branch 'develop' into Make-files-available-offline
ohassine 12e6365
fix: incorrect icon usage
ohassine a30de5a
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine 204ae28
fix: detekt
ohassine bd1a0df
fix: lint
ohassine 15042f2
feat: display offline files
ohassine 0d713bc
feat: display offline files
ohassine c5225a5
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine a334c17
feat: display offline files
ohassine af93b1d
feat: cleanup
ohassine b59a08f
feat: cleanup
ohassine c51175a
feat: support offline mode in search screen
ohassine 389525d
chore: cleanup
ohassine 6489c30
chore: kalium
ohassine 11509a2
Merge remote-tracking branch 'origin/develop' into display-offline-files
ohassine 952a1ae
chore: lint
ohassine 1ebbcbd
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine bb0cda9
Merge branch 'Make-files-available-offline' into display-offline-files
ohassine 785f817
chore: cleanup
ohassine 065917d
chore: add conversationId
ohassine bea8de1
chore: add conversationId
ohassine 9cc0b51
chore: kalium reference
ohassine b9cdfef
chore: test
ohassine e4aadf2
chore: detekt
ohassine 3cc3b57
Merge branch 'develop' into Make-files-available-offline
ohassine 155c2d1
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine 0d26300
Merge branch 'Make-files-available-offline' into display-offline-files
ohassine 3965331
chore: detekt
ohassine 6125be1
chore: kalium
ohassine 27f686e
chore: test
ohassine e44bd6f
Merge branch 'Make-files-available-offline' into display-offline-files
ohassine d4c75c1
chore: test
ohassine 8c63ab4
chore: detekt
ohassine c69e635
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine 92c9caa
chore: cleanup
ohassine 7bedbad
refactor: add mimeType
ohassine dffb611
feat: show offline indicator for files in conversation
ohassine 6776d9b
feat: Display offline files (WPB-23968) (#4822)
ohassine e7cddfc
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine de22055
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine 9b8a5bb
chore: detekt
ohassine 8f60e28
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine aac5ec9
chore: cleanup
ohassine 5bba7d3
chore: pass conversationId using savedStateHandle instead of Assisted…
ohassine d867d23
chore: kalium
ohassine addc7c8
feat: test
ohassine 5f92202
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine 9400085
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine a409487
feat: kalium ref
ohassine 1f60146
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine 3ef3638
refactor: move mapping to viewmodel
ohassine e63df09
refactor: address comments
ohassine 63a0e33
feat: use case for observing offline files by conversationId
ohassine d1ba210
feat: cleanup
ohassine ce7922f
Merge remote-tracking branch 'origin/develop' into Make-files-availab…
ohassine 8a97919
Merge remote-tracking branch 'origin/Make-files-available-offline' in…
ohassine b90294c
chore: conflicts
ohassine 4060c21
Merge remote-tracking branch 'origin/develop' into show-offline-indic…
ohassine cb0adc6
chore: merge conflicts
ohassine 94bf45b
chore: cleanup
ohassine 9624bba
feat: cleanup
ohassine 5db0d61
Merge branch 'develop' into show-offline-indicator-for-files-in-conve…
ohassine ba854dd
Merge remote-tracking branch 'origin/develop' into show-offline-indic…
ohassine 55a332e
feat: kalium
ohassine 4b61197
feat: kalium
ohassine f9c1607
feat: test
ohassine b265e47
feat: test
ohassine f40e306
feat: test
ohassine 6fc9d3b
feat: test
ohassine d8caed8
feat: test
ohassine 9a508a0
feat: detekt
ohassine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: do not expose offlineAttachmentIds outside of viewmodel just for mapping.
Add mapAttachment(attachment) method for mapping one attachment and then both mapAttachment/mapAttachments can do the mapping using private offlineAttachmentIds in viewmodel.