Feat: add warning to connection requests

Author: marcoconti83

README.md

@@ -63,6 +63,8 @@ To rebuild a dependency and use it in the umbrella project, run:
 carthage bootstrap --platform ios --use-xcframeworks
 ```
 
+To run tests, make sure to use a simulated iPhone 17 with iOS 26.1, as reference screenshot tests rely on that layout.
+
 ### Known Limitations
 
 Notifications sent through the Apple Push Notification service can only be received by the App Store Wire client, which is code-signed with Wire's own certificate. This is a security feature enforced by Apple, as documented in Apple's [Local and Remote Notification Programming Guide](https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/). Any client built from source will not be able to receive notifications.

wire-ios/Wire-iOS Tests/ReferenceImages/IncomingConnectionViewTests/testThatItRendersWithUnconnectedUser.1.png

@@ -5011,13 +5011,15 @@ internal enum L10n {
         /// Guest
         internal static let guest = L10n.tr("Localizable", "profile.details.guest", fallback: "Guest")
         /// Get certainty about %@’s identity before connecting.
+        /// Wire’s Support team will never reach out to you in the app.
         internal static func identityWarning(_ p1: Any) -> String {
-          return L10n.tr("Localizable", "profile.details.identity_warning", String(describing: p1), fallback: "Get certainty about %@’s identity before connecting.")
+          return L10n.tr("Localizable", "profile.details.identity_warning", String(describing: p1), fallback: "Get certainty about %@’s identity before connecting.\nWire’s Support team will never reach out to you in the app.")
         }
         /// external
         internal static let partner = L10n.tr("Localizable", "profile.details.partner", fallback: "external")
         /// Please verify the person's identity before accepting the connection request.
-        internal static let requestedIdentityWarning = L10n.tr("Localizable", "profile.details.requested_identity_warning", fallback: "Please verify the person's identity before accepting the connection request.")
+        /// Wire’s Support team will never reach out to you in the app.
+        internal static let requestedIdentityWarning = L10n.tr("Localizable", "profile.details.requested_identity_warning", fallback: "Please verify the person's identity before accepting the connection request.\nWire’s Support team will never reach out to you in the app.")
         /// Details
         internal static let title = L10n.tr("Localizable", "profile.details.title", fallback: "Details")
         internal enum Title {

wire-ios/Wire-iOS Tests/ReferenceImages/ProfileDetailsViewControllerTests/test_Group_BlockingConnectionRequest_MissingLegalHoldConsent1.1.png

@@ -1063,8 +1063,8 @@
 "profile.details.partner" = "external";
 "profile.details.federated" = "Federated";
 "profile.details.blocking_reason" = "This user is blocked due to legal hold. [LEARN MORE](%@)";
-"profile.details.identity_warning" = "Get certainty about %@’s identity before connecting.";
-"profile.details.requested_identity_warning" = "Please verify the person's identity before accepting the connection request.";
+"profile.details.identity_warning" = "Get certainty about %@’s identity before connecting.\nWire’s Support team will never reach out to you in the app.";
+"profile.details.requested_identity_warning" = "Please verify the person's identity before accepting the connection request.\nWire’s Support team will never reach out to you in the app.";
 "profile.details.title.unavailable" = "Name not available";
 
 // Device list

wire-ios/Wire-iOS Tests/ReferenceImages/ProfileDetailsViewControllerTests/test_Group_ConnectionRequest.1.png

@@ -22,14 +22,20 @@ import WireDataModel
 import WireDesign
 
 final class WarningLabelView: UIView {
-    private let stackView = UIStackView(axis: .horizontal)
-    private let imageView = UIImageView(image: UIImage(named: "Info"))
+    private let stackView = UIStackView(axis: .vertical)
 
     private let label = DynamicFontLabel(
         style: .h5,
         color: SemanticColors.Label.textErrorDefault
     )
 
+    private static let paragraphStyle: NSParagraphStyle = {
+        let style = NSMutableParagraphStyle()
+        style.paragraphSpacing = 8
+        style.alignment = .center
+        return style
+    }()
+
     // MARK: - Setup
 
     init() {
@@ -45,18 +51,12 @@ final class WarningLabelView: UIView {
     private func setupViews() {
         stackView.translatesAutoresizingMaskIntoConstraints = false
         addSubview(stackView)
-        stackView.alignment = .top
+        stackView.alignment = .center
         stackView.spacing = 10
-        imageView.tintColor = SemanticColors.Icon.foregroundDefaultRed
-        stackView.addArrangedSubview(imageView)
         label.numberOfLines = 0
         stackView.addArrangedSubview(label)
         NSLayoutConstraint.activate(
-            [
-                imageView.widthAnchor.constraint(equalToConstant: 16.0),
-                imageView.heightAnchor.constraint(equalToConstant: 16.0)
-            ] +
-                NSLayoutConstraint.forView(
+            NSLayoutConstraint.forView(
                     view: stackView,
                     inContainer: self,
                     withInsets: .zero
@@ -68,14 +68,17 @@ final class WarningLabelView: UIView {
         typealias profileDetails = L10n.Localizable.Profile.Details
         if user.isPendingApprovalBySelfUser {
             isHidden = false
-            label.text = profileDetails.requestedIdentityWarning
+            label.attributedText = attributedWarning(profileDetails.requestedIdentityWarning)
         }
         guard let name = user.name else {
             isHidden = true
             return
         }
         isHidden = user.isConnected || user.isTeamMember || user.isSelfUser
-        label.text = profileDetails.identityWarning(name)
+        label.attributedText = attributedWarning(profileDetails.identityWarning(name))
+    }
 
+    private func attributedWarning(_ text: String) -> NSAttributedString {
+        NSAttributedString(string: text, attributes: [.paragraphStyle: Self.paragraphStyle])
     }
 }