Skip to content

feat: adjust dark mode color - WPB-22723#4627

Open
netbe wants to merge 40 commits into
developfrom
feat/adjust-dark-mode-color-WPB-22723
Open

feat: adjust dark mode color - WPB-22723#4627
netbe wants to merge 40 commits into
developfrom
feat/adjust-dark-mode-color-WPB-22723

Conversation

@netbe
Copy link
Copy Markdown
Collaborator

@netbe netbe commented Apr 24, 2026

TaskWPB-22723 [iOS] Adjust dark mode color scheme

Issue

  • Adjust colors in darkmode
  • Update ColorTheme and deprecate SemanticsColors
  • Add support for blockquotes
  • Redesign replies
  • Alignment of chatbubbles under sendername

Testing

  • Design review build: Playground 🟡(version: 4.19.0 build: 18456)

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

fileprivate static func defaultMarkdownStyle() -> DownStyle {
let style = DownStyle.normal

style.baseFont = UIFont.normalLightFont
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here the font change to respect the desgin

@netbe netbe marked this pull request as ready for review May 12, 2026 08:33
@netbe netbe requested review from David-Henner and caldrian May 12, 2026 08:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Test Results

    2 files    343 suites   3m 24s ⏱️
2 046 tests 2 010 ✅ 28 💤 8 ❌
2 046 runs  2 011 ✅ 28 💤 7 ❌

For more details on these failures, see this check.

Results for commit b706937.

♻️ This comment has been updated with latest results.

Summary: workflow run #26102634239
Allure report (download zip): html-report-30121-feat_adjust-dark-mode-color-WPB-22723

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented May 12, 2026

Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 7 Tests failed

testThatItRendersButton() from Wire-iOS-Tests.CompositeMessageCellTests   View in Datadog   (Fix with Cursor)
CompositeMessageCellTests.swift:68: XCTAssertNil failed: "Snapshot "414.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/CompositeMessageCellTests/testThatItRendersButton.414-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/CompositeMessageCellTests/testThatItRendersButton.414-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...
testThatItRendersErrorMessage() from Wire-iOS-Tests.CompositeMessageCellTests   View in Datadog   (Fix with Cursor)
CompositeMessageCellTests.swift:60: XCTAssertNil failed: "Snapshot "320.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/CompositeMessageCellTests/testThatItRendersErrorMessage.320-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/CompositeMessageCellTests/testThatItRendersErrorMessage.320-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...
❄️ Known flaky: testForAllPhoneWidths() from Wire-iOS-Tests.GroupDetailsFooterViewTests   View in Datadog   (Fix with Cursor)
GroupDetailsViewControllerTests.swift:43: XCTAssertNil failed: "Snapshot "320.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/GroupDetailsViewControllerTests/testForAllPhoneWidths.320-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/GroupDetailsViewControllerTests/testForAllPhoneWidths.320-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b706937 | Docs | Give us feedback!

@netbe netbe added the WIP label May 19, 2026
@sonarqubecloud
Copy link
Copy Markdown

@netbe netbe removed the WIP label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant