feat: discover team members in large teams - WPB-24947 by caldrian · Pull Request #4720 · wireapp/wire-ios

caldrian · 2026-05-18T08:39:05Z

WPB-24947 [iOS] Use /teams/notifications to discover members and apps in large teams

Issue

This PR adds a new step for reliably discovering all team members to the incremental sync.
Before we would only get 2000 members (and potentially some more from shared conversations).
Now the iOS client should stay up to date about joined team members.

Testing

Create a large team of more than 2000 members. Ensure the iOS app always knows about all team members (including apps).

Checklist

Title contains a reference JIRA issue number like [WPB-XXX].
Description is filled and free of optional paragraphs.
Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

Make sure you use the API for UI elements that support large fonts.
All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
New UI elements have Accessibility strings for VoiceOver.

…-team-notifications-WPB-24947

Copilot

Pull request overview

This PR improves large-team member discovery by using /teams/notifications (inclusive cursor semantics) as part of incremental sync, persisting a cursor in Journal, and handling server retention gaps via a dedicated missedEvents error.

Changes:

Add TeamMemberDiscoveryAgent (and protocol + journal key) and integrate it into IncrementalSync and IncrementalSyncV2.
Update WireNetwork team notifications modeling to include a notification envelope id and enforce inclusive-cursor semantics (filter cursor item; throw on missing cursor).
Extend/adjust tests and request snapshots for the new cursor behavior and error case.

Reviewed changes

Copilot reviewed 36 out of 37 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/TeamsAPITests.swift	Updates notifications expectations to include envelope IDs and adds tests for inclusive cursor filtering + missed-events handling.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v5.txt	Adds request snapshot for v5.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v6.txt	Adds request snapshot for v6.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v7.txt	Adds request snapshot for v7.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v8.txt	Adds request snapshot for v8.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v9.txt	Adds request snapshot for v9.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v10.txt	Adds request snapshot for v10.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v11.txt	Adds request snapshot for v11.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v12.txt	Adds request snapshot for v12.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v13.txt	Adds request snapshot for v13.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v14.txt	Adds request snapshot for v14.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorMatchesFirstResponseItem_thenFiltersThatItem.request-0-v15.txt	Adds request snapshot for v15.
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v5.txt	Adds request snapshot for missed-events test (v5).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v6.txt	Adds request snapshot for missed-events test (v6).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v7.txt	Adds request snapshot for missed-events test (v7).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v8.txt	Adds request snapshot for missed-events test (v8).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v9.txt	Adds request snapshot for missed-events test (v9).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v10.txt	Adds request snapshot for missed-events test (v10).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v11.txt	Adds request snapshot for missed-events test (v11).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v12.txt	Adds request snapshot for missed-events test (v12).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v13.txt	Adds request snapshot for missed-events test (v13).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v14.txt	Adds request snapshot for missed-events test (v14).
WireNetwork/Tests/WireNetworkTests/APIs/Rest/TeamsAPI/Snapshots/TeamsAPITests/testTeamNotifications_givenSinceCursorIsMissingFromResponse_thenThrowsMissedEvents.request-0-v15.txt	Adds request snapshot for missed-events test (v15).
WireNetwork/Sources/WireNetwork/Models/Team/TeamNotification.swift	Changes `TeamNotification` to a struct with `id` (cursor) + `kind`.
WireNetwork/Sources/WireNetwork/APIs/Rest/TeamsAPI/TeamsAPIV5.swift	Enforces inclusive-cursor semantics: filter cursor item and throw `missedEvents` if cursor is absent.
WireNetwork/Sources/WireNetwork/APIs/Rest/TeamsAPI/TeamsAPIError.swift	Adds `TeamsAPIError.missedEvents`.
WireNetwork/Sources/WireNetwork/APIs/Rest/TeamsAPI/Responses/TeamNotificationV5.swift	Maps decoded payload items into `TeamNotification(id:kind:)`.
WireNetwork/Sources/WireNetwork/APIs/Rest/TeamsAPI/EventDecoding/TeamNotificationDecodingProxy.swift	Refactors decoding proxy to decode `TeamNotification.Kind` (separating envelope `id` from event kind).
WireDomain/Tests/WireDomainTests/Synchronization/IncrementalSyncV2Tests.swift	Injects a `TeamMemberDiscoveryAgentProtocol` mock into `IncrementalSyncV2` tests.
WireDomain/Tests/WireDomainTests/Synchronization/IncrementalSyncTests.swift	Injects a `TeamMemberDiscoveryAgentProtocol` mock into `IncrementalSync` tests.
WireDomain/Sources/WireDomainSupport/Sourcery/generated/AutoMockable.generated.swift	Adds a generated mock for `TeamMemberDiscoveryAgentProtocol`.
WireDomain/Sources/WireDomain/Utilities/Journal/JournalKey.swift	Adds `JournalKey.lastTeamNotificationID` for persisting the notifications cursor.
WireDomain/Sources/WireDomain/Synchronization/TeamMemberDiscoveryAgent.swift	Adds the agent that pages notifications, stores discovered members, and persists/reset cursor.
WireDomain/Sources/WireDomain/Synchronization/Protocols/TeamMemberDiscoveryAgentProtocol.swift	Introduces the discovery agent protocol (AutoMockable).
WireDomain/Sources/WireDomain/Synchronization/IncrementalSyncV2.swift	Calls team member discovery during sync V2 flow.
WireDomain/Sources/WireDomain/Synchronization/IncrementalSync.swift	Calls team member discovery during sync (skipping background-accessible-only mode).
WireDomain/Sources/WireDomain/Components/ClientSessionComponent.swift	Wires `TeamMemberDiscoveryAgent` into both incremental sync implementations.

Comments suppressed due to low confidence (1)

WireDomain/Tests/WireDomainTests/Synchronization/IncrementalSyncV2Tests.swift:98

MockTeamMemberDiscoveryAgentProtocol will fatalError("no mock for discoverMembers") unless discoverMembers_MockMethod is set. Because IncrementalSyncV2.perform() now calls teamMemberDiscoveryAgent.discoverMembers(), any test executing sut.perform() will crash unless the mock is configured. Set teamMemberDiscoveryAgentMock.discoverMembers_MockMethod in setUp (no-op) and optionally assert it was invoked.

        mlsGroupRepairAgent = MockMLSGroupRepairAgentProtocol()
        liveBrokenGroupSubject = .init()
        cancellables = .init()
        earService = MockEARServiceInterface()
        teamMemberDiscoveryAgentMock = MockTeamMemberDiscoveryAgentProtocol()

        sut = IncrementalSyncV2(
            selfClientID: Scaffolding.selfClientID,
            pullServerTimeSync: pullServerTimeSync,
            pushChannelAPI: pushChannelAPI,
            decryptor: decryptor,
            updateEventsStore: updateEventsStore,
            messageStore: messageLocalStore,
            processor: processor,
            databaseSaver: databaseSaver,
            syncStateSubject: syncStateSubject,
            liveBrokenGroupSubject: liveBrokenGroupSubject,
            coreCryptoProvider: coreCryptoProvider,
            journal: journal,
            mlsGroupRepairAgent: mlsGroupRepairAgent,
            earService: earService,
            teamMemberDiscoveryAgent: teamMemberDiscoveryAgentMock,
            createPushChannelState: {
                self.pushChannelState
            },
            syncMarkerGenerator: { Scaffolding.markerID }
        )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-05-19T09:06:22Z

Test Results

2 files 177 suites 21s ⏱️
930 tests 930 ✅ 0 💤 0 ❌
931 runs 931 ✅ 0 💤 0 ❌

Results for commit e8b1b9b.

♻️ This comment has been updated with latest results.

Summary: workflow run #26148431862
Allure report (download zip): html-report-30136-feat_query-team-notifications-WPB-24947

…-team-notifications-WPB-24947 # Conflicts: # WireDomain/Tests/WireDomainTests/Synchronization/IncrementalSyncV2Tests.swift

sonarqubecloud · 2026-05-20T07:43:12Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

samwyndham

Nice work!

samwyndham · 2026-05-20T08:56:56Z

+
+        var discoveredCount = 0
+        for try await notifications in pager {
+            let teamMembersInfo = notifications.map { notification -> TeamMemberInfo in


nit-pick(subjective): Consider renaming teamMemberInfos to make it clear that this is an collection

github-actions Bot assigned caldrian May 18, 2026

generate TeamMemberDiscoveryAgent

2e59f37

caldrian force-pushed the feat/query-team-notifications-WPB-24947 branch from c40ca22 to 2e59f37 Compare May 18, 2026 08:43

caldrian added 13 commits May 18, 2026 10:55

finish implementation

66b9b22

persist last id

56510ce

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/query…

29bab2f

…-team-notifications-WPB-24947

fix build errors

ff7a378

add temporary code

bb75833

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/query…

eccfe5b

…-team-notifications-WPB-24947

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/query…

7310667

…-team-notifications-WPB-24947

inclusive since cursor

0ef13fd

move logic

67d3909

generate test

fde00ad

cleanup

25baea1

missed events detection

b5b9a1d

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/query…

f1ffdc9

…-team-notifications-WPB-24947

caldrian changed the title ~~feat: discover team members in large teams - WPB-24947~~ feat: discover team members in large teams - WPB-24947x' May 19, 2026

caldrian changed the title ~~feat: discover team members in large teams - WPB-24947x'~~ feat: discover team members in large teams - WPB-24947 May 19, 2026

caldrian marked this pull request as ready for review May 19, 2026 08:47

add missing files

6d8a95a

caldrian requested review from Copilot, netbe and samwyndham and removed request for Copilot and netbe May 19, 2026 08:56

Copilot started reviewing on behalf of caldrian May 19, 2026 08:57 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

Comment thread WireDomain/Tests/WireDomainTests/Synchronization/IncrementalSyncTests.swift

Comment thread WireDomain/Sources/WireDomain/Synchronization/TeamMemberDiscoveryAgent.swift

add TeamMemberDiscoveryAgentTests

f283cc1

wireapp deleted a comment from datadog-wireapp Bot May 19, 2026

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/query…

e8b1b9b

…-team-notifications-WPB-24947 # Conflicts: # WireDomain/Tests/WireDomainTests/Synchronization/IncrementalSyncV2Tests.swift

caldrian enabled auto-merge May 20, 2026 07:36

samwyndham approved these changes May 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: discover team members in large teams - WPB-24947#4720

feat: discover team members in large teams - WPB-24947#4720
caldrian wants to merge 17 commits into
developfrom
feat/query-team-notifications-WPB-24947

caldrian commented May 18, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented May 20, 2026

Uh oh!

samwyndham left a comment

Uh oh!

samwyndham May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

caldrian commented May 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Testing

Checklist

UI accessibility checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

sonarqubecloud Bot commented May 20, 2026

Quality Gate passed

Uh oh!

samwyndham left a comment

Choose a reason for hiding this comment

Uh oh!

samwyndham May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

caldrian commented May 18, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading