fix: certificate enrollment view not displayed by developer tools - WPB-24270 🍒 🍒#4723
Queued
github-actions[bot] wants to merge 2 commits into
Conversation
…PB-24270 🍒 (#4710) Co-authored-by: David-Henner <david.henner@wire.com>
…ayed-by-developer-tools-cherry-pick-cherry-pick
zenkins
approved these changes
May 20, 2026
Collaborator
zenkins
left a comment
zenkins
left a comment
There was a problem hiding this comment.
✅ Auto-approved cherry-pick PR 🍒.
|
Contributor
Author
Test Results1 891 tests 1 864 ✅ 2m 1s ⏱️ Results for commit 07dafaf. Summary: workflow run #26164026193 |
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
The certificate enrollment view is not being displayed by the developer tools menu when tapping on the
enrollbutton.Cause
The developer tools sheet has
modalPresentationStyle != .fullScreen, so the while loop intopmostViewControllerstops one level too early and returns the parent VC — not the developer tools VC. However, the parent VC already has apresentedViewController(the developer tools sheet), sopresent()fails silently.This only affects builds that have
SecurityFlags.useEmbeddedIDPUserAgentevaluate totrue, because in this caseWebViewUserAgentis used. It relies on atargetViewControllerto be presented. That target VC is the one captured bytopmostViewController()Builds with
SecurityFlags.useEmbeddedIDPUserAgentevaluating tofalserely onOIDExternalUserAgentIOS, which uses the window directly, instead of a target VC.Solution
use
topmostViewController(onlyFullScreen: false)to find and use the developer tools sheet as target VCChecklist
[WPB-XXX].