Skip to content

revert: fix: prevent main app from blocking notification extension (take 2) - WPB-23511#4735

Open
johnxnguyen wants to merge 2 commits into
release/cycle-4.19from
revert/nse-fix-2
Open

revert: fix: prevent main app from blocking notification extension (take 2) - WPB-23511#4735
johnxnguyen wants to merge 2 commits into
release/cycle-4.19from
revert/nse-fix-2

Conversation

@johnxnguyen
Copy link
Copy Markdown
Collaborator

@johnxnguyen johnxnguyen commented May 19, 2026

BugWPB-23511 [iOS] NSE is often getting stuck and expiring

This reverts commit 425860d.

Issue

Builds with this #4689 exhibit the bug, so reverting it and will try again.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Copy Markdown
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@johnxnguyen johnxnguyen enabled auto-merge (squash) May 19, 2026 13:41
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Test Results – WireRequestStrategy

965 tests   965 ✅  46s ⏱️
108 suites    0 💤
  1 files      0 ❌

Results for commit 1cb01d6.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results – WireUIAll

161 tests   160 ✅  57s ⏱️
 41 suites    1 💤
  1 files      0 ❌

Results for commit 1cb01d6.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results – WireShareEngine

15 tests   15 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 1cb01d6.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results – WireAuthenticationAll

106 tests   106 ✅  9s ⏱️
 22 suites    0 💤
  1 files      0 ❌

Results for commit 1cb01d6.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results – WireDomain

  1 files  139 suites   15s ⏱️
547 tests 547 ✅ 0 💤 0 ❌
548 runs  548 ✅ 0 💤 0 ❌

Results for commit 1cb01d6.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results – Wire-iOS

1 865 tests   1 838 ✅  2m 1s ⏱️
  300 suites     27 💤
    1 files        0 ❌

Results for commit 1cb01d6.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results – WireSyncEngine

1 106 tests   1 106 ✅  1m 17s ⏱️
  133 suites      0 💤
    1 files        0 ❌

Results for commit 1cb01d6.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Test Results – WireDataModel

2 377 tests   2 377 ✅  3m 38s ⏱️
  245 suites      0 💤
    1 files        0 ❌

Results for commit 1cb01d6.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants