Skip to content

fix: prevent main app from blocking notification extension (take 3) - WPB-23511#4738

Queued
johnxnguyen wants to merge 4 commits into
developfrom
fix/nse-stuck
Queued

fix: prevent main app from blocking notification extension (take 3) - WPB-23511#4738
johnxnguyen wants to merge 4 commits into
developfrom
fix/nse-stuck

Conversation

@johnxnguyen
Copy link
Copy Markdown
Collaborator

@johnxnguyen johnxnguyen commented May 20, 2026

BugWPB-23511 [iOS] NSE is often getting stuck and expiring

Issue

This is another attempt to fixing an issue where Core Crypto transactions can sometimes be suspended before completing, preventing CCs internal process locking mechanism from releasing the lock, resulting in other processes being unable to perform transactions.

The previous attempt #4689 used background tasks when performing Core Crypto transactions, but it was observed that it didn't always work. On top of that, the background task API was only available in the main app target and not the extensions.

This PR builds on the previous attempt by using the expiring activity API via ExpiringActivityManager, which is available in all app processes.

For more information about the issue and testing, see #4689 .


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Comment thread wire-ios-system/Source/ExpiringActivity.swift
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Results – WireSystem

86 tests   83 ✅  1s ⏱️
13 suites   3 💤
 1 files     0 ❌

Results for commit 7628673.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Results – WireDomain

  1 files  139 suites   15s ⏱️
547 tests 547 ✅ 0 💤 0 ❌
548 runs  548 ✅ 0 💤 0 ❌

Results for commit 7628673.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Results – WireShareEngine

15 tests   15 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 7628673.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Results – WireSyncEngine

1 106 tests   1 106 ✅  1m 20s ⏱️
  133 suites      0 💤
    1 files        0 ❌

Results for commit 7628673.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Results – WireRequestStrategy

965 tests   965 ✅  43s ⏱️
108 suites    0 💤
  1 files      0 ❌

Results for commit 7628673.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Results – WireDataModel

2 377 tests   2 377 ✅  4m 25s ⏱️
  245 suites      0 💤
    1 files        0 ❌

Results for commit 7628673.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Comment thread wire-ios-data-model/Source/Core Crypto/SafeCoreCrypto.swift
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@johnxnguyen johnxnguyen enabled auto-merge May 20, 2026 11:45
@johnxnguyen johnxnguyen added this pull request to the merge queue May 20, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants