feat: add offline available icon to preview header - WPB-25602#4739
feat: add offline available icon to preview header - WPB-25602#4739OlivellaO wants to merge 1 commit into
Conversation
|
Test Results303 tests 303 ✅ 1m 42s ⏱️ Results for commit 6b2b3c5. Summary: workflow run #26146940426 |
WilhelmOks
left a comment
WilhelmOks
left a comment
There was a problem hiding this comment.
looking good but needs changes on the icon render functions
| .resizable() | ||
| .frame(width: 10, height: 10) | ||
| .foregroundStyle(ColorTheme.Base.secondaryText.color) | ||
| .accessibilityLabel("Offline available") |
There was a problem hiding this comment.
the text label needs to be localized.
btw, I think this is grammatically wrong. It should be "Available offline". Might be a literal translation from German.
| @@ -176,6 +176,7 @@ struct FilesItemView: View { | |||
| .resizable() | |||
| .frame(width: 10, height: 10) | |||
There was a problem hiding this comment.
a fixed size will probably look bad on different scales. I suggest to make it adapt to the text size of the text that it is next to
| .resizable() | ||
| .frame(width: 10, height: 10) | ||
| .foregroundStyle(ColorTheme.Base.secondaryText.color) | ||
| .accessibilityLabel("Offline available") |
There was a problem hiding this comment.
please see my other comments on the same function
There was a problem hiding this comment.
also, since this is an exact copy, I suggest to extract it into a separate mini component (SwiftUI View)
2 participants
Issue
Add icon next to the file name on Previews for offline available files
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: