fix: reduce memory pressure#4857
Draft
netbe wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
Xcode Organizer shows our Background Terminations rising ~3× from 4.7.0 (~1.7/day) to 4.12.2 (~6.5/day), then plateauing. The category breakdown is 98% "System Pressure" (memory-pressure jetsam of the suspended app) — 0% File Lock, 0% Task Timeout. So this is not a CoreCrypto file-lock issue (0xDEAD10CC) and not an ExpiringActivity/watchdog issue; it's the backgrounded app's memory footprint making it a prime jetsam target.
Root cause: the in-memory image caches (UIImage.defaultUserImageCache, MediaAssetCache.defaultImageCache, and the global defaultUserImageCache) are unbounded NSCaches that are never released when the app backgrounds. NSCache only evicts reliably in the foreground, so decoded images accumulated during use stay resident while suspended. The rise tracks new image surfaces added over those releases (e.g. WPB-16312 cells image previews).
Change
Register for UIApplication.didEnterBackgroundNotification inside ImageCache.init and removeAllObjects() on background. Placing it in the type means all instances get the behavior with no call-site changes; observer is torn down in deinit.
Impact
Smaller resident footprint while suspended → fewer "System Pressure" background terminations. Foreground behavior is unchanged (caches refill on demand).
Validation
Measure backgrounded memory footprint before/after, and watch the System Pressure background-termination rate in Organizer post-release (the only category this should move).
Testing
TBD
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: