Skip to content

chore: add localization reminder workflow#4905

Open
netbe wants to merge 3 commits into
developfrom
chore/new-localization-workflow
Open

chore: add localization reminder workflow#4905
netbe wants to merge 3 commits into
developfrom
chore/new-localization-workflow

Conversation

@netbe

@netbe netbe commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Issue

Adds a GitHub Actions workflow that comments on a PR when new localization strings are introduced. The comment lists each new key with its English value and reminds contributors to ensure German translations are completed after merging to develop.

The workflow triggers on changes to en.lproj/*.strings and *.xcstrings files. It detects only genuinely added keys (not edits or deletions), and updates the comment in place on each push so the list stays accurate.

Testing

  1. Open a PR that adds a new key to an en.lproj/*.strings file — verify a comment appears listing the key and its English value.
  2. Open a PR that adds a new key to an .xcstrings file — verify the comment shows the correct English value fetched via jq.
  3. Push a follow-up commit adding more strings — verify the comment is updated rather than duplicated.
  4. Open a PR with no localization changes — verify no comment is posted.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

netbe and others added 2 commits June 23, 2026 22:58
Posts a PR comment listing new English string keys and values when .strings or .xcstrings files are changed, reminding contributors to ensure German translations are completed after merging to develop.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 14468e6.

♻️ This comment has been updated with latest results.

Summary: workflow run #28061226144

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant