chore: UItest - theme change, profile color with background color and profile picture - WPB-26418#4921
Conversation
Test Results2 100 tests 2 072 ✅ 3m 41s ⏱️ Results for commit 783695f. ♻️ This comment has been updated with latest results. Summary: workflow run #28773805335 |
There was a problem hiding this comment.
Pull request overview
This PR adds new UI tests around theme switching, profile picture selection, and verifying profile/conversation background color behavior, and wires up additional accessibility identifiers/values in the app’s settings/profile UI to support that automation.
Changes:
- Add new
SettingsTestscovering theme selection, display picture, and profile color + conversation background verification. - Introduce new WireLocators entries and a new
ThemeSettingsPagepage object for stable element lookup. - Extend Settings/Profile/Conversation UI components to expose accessibility identifiers/values needed by the new UI tests.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| WireUI/Sources/WireLocators/Locators.swift | Adds new locators for theme options, account picture/color cells, and conversation background. |
| wire-ios/WireUITests/SettingsTests.swift | Adds new UI test cases for theme switching, display picture, and profile/background color behavior. |
| wire-ios/WireUITests/Pages/UserProfilePage.swift | Adds assertion helper to verify a profile picture is set via accessibility value. |
| wire-ios/WireUITests/Pages/ThemeSettingsPage.swift | New page object to drive and assert theme settings UI. |
| wire-ios/WireUITests/Pages/OptionsOnSettingsPage.swift | Adds theme cell/button access and theme verification helpers. |
| wire-ios/WireUITests/Pages/ActiveConversationPage.swift | Adds locator and verification for conversation background accessibility value. |
| wire-ios/WireUITests/Pages/AccountSettingsPage.swift | Adds flows for selecting profile color, enabling conversation background, and selecting a profile picture from the library. |
| wire-ios/Wire-iOS/Sources/UserInterface/Settings/SettingsAppearanceCell.swift | Sets accessibilityValue for picture/color previews to support UI assertions. |
| wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsPropertySelectValueCellDescriptor.swift | Adds accessibility value generator support for settings value cells. |
| wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Options.swift | Wires theme option identifiers + debug accessibilityValue format for tests. |
| wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift | Assigns locators to picture/color cells and conversation background switch. |
| wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptor.swift | Propagates accessibility identifier/value from descriptors onto table cells. |
| wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsAppearanceCellDescriptor.swift | Adds identifier passthrough to appearance cell for UI automation. |
| wire-ios/Wire-iOS/Sources/UserInterface/SelfProfile/ProfileHeaderViewController.swift | Updates profile picture accessibilityValue when image changes. |
| wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController.swift | Exposes conversation background identifier/value on the table view for UI tests. |
| wire-ios/Wire-iOS/Sources/UserInterface/Components/UserImageView.swift | Sets accessibilityValue based on whether avatar is an image or initials. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
samwyndham
left a comment
There was a problem hiding this comment.
Looks good although I think we should avoid having too many of these dynamic identifiers around the codebase as it can become hard to reason about. I wonder if we should consider adding image snapshot testing to our UI tests for such kinds of tests.
|



Issue
Please describe the issue.
new UITests - theme change, profile color with background color and profile picture
Testing
Describe how to test.
Ran locally

ThemeChange.mp4
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: