Skip to content

chore: UItest - theme change, profile color with background color and profile picture - WPB-26418#4921

Merged
findms merged 10 commits into
developfrom
chore/ms-test-theme-color-image-tests
Jul 6, 2026
Merged

chore: UItest - theme change, profile color with background color and profile picture - WPB-26418#4921
findms merged 10 commits into
developfrom
chore/ms-test-theme-color-image-tests

Conversation

@findms

@findms findms commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
TaskWPB-26418 [iOS] Automate - profile color, display picture,, theme tests

Issue

Please describe the issue.

new UITests - theme change, profile color with background color and profile picture

Testing

Describe how to test.

Ran locally
image

ThemeChange.mp4

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@findms findms changed the title chore: test - theme change, profile color with background color and profile picture - WPB-26418 chore: UItest - theme change, profile color with background color and profile picture - WPB-26418 Jun 24, 2026
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 100 tests   2 072 ✅  3m 41s ⏱️
  345 suites     28 💤
    2 files        0 ❌

Results for commit 783695f.

♻️ This comment has been updated with latest results.

Summary: workflow run #28773805335
Allure report (download zip): html-report-31502-chore_ms-test-theme-color-image-tests

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new UI tests around theme switching, profile picture selection, and verifying profile/conversation background color behavior, and wires up additional accessibility identifiers/values in the app’s settings/profile UI to support that automation.

Changes:

  • Add new SettingsTests covering theme selection, display picture, and profile color + conversation background verification.
  • Introduce new WireLocators entries and a new ThemeSettingsPage page object for stable element lookup.
  • Extend Settings/Profile/Conversation UI components to expose accessibility identifiers/values needed by the new UI tests.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
WireUI/Sources/WireLocators/Locators.swift Adds new locators for theme options, account picture/color cells, and conversation background.
wire-ios/WireUITests/SettingsTests.swift Adds new UI test cases for theme switching, display picture, and profile/background color behavior.
wire-ios/WireUITests/Pages/UserProfilePage.swift Adds assertion helper to verify a profile picture is set via accessibility value.
wire-ios/WireUITests/Pages/ThemeSettingsPage.swift New page object to drive and assert theme settings UI.
wire-ios/WireUITests/Pages/OptionsOnSettingsPage.swift Adds theme cell/button access and theme verification helpers.
wire-ios/WireUITests/Pages/ActiveConversationPage.swift Adds locator and verification for conversation background accessibility value.
wire-ios/WireUITests/Pages/AccountSettingsPage.swift Adds flows for selecting profile color, enabling conversation background, and selecting a profile picture from the library.
wire-ios/Wire-iOS/Sources/UserInterface/Settings/SettingsAppearanceCell.swift Sets accessibilityValue for picture/color previews to support UI assertions.
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsPropertySelectValueCellDescriptor.swift Adds accessibility value generator support for settings value cells.
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Options.swift Wires theme option identifiers + debug accessibilityValue format for tests.
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift Assigns locators to picture/color cells and conversation background switch.
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptor.swift Propagates accessibility identifier/value from descriptors onto table cells.
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsAppearanceCellDescriptor.swift Adds identifier passthrough to appearance cell for UI automation.
wire-ios/Wire-iOS/Sources/UserInterface/SelfProfile/ProfileHeaderViewController.swift Updates profile picture accessibilityValue when image changes.
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController.swift Exposes conversation background identifier/value on the table view for UI tests.
wire-ios/Wire-iOS/Sources/UserInterface/Components/UserImageView.swift Sets accessibilityValue based on whether avatar is an image or initials.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wire-ios/WireUITests/Pages/OptionsOnSettingsPage.swift
Comment thread wire-ios/WireUITests/Pages/AccountSettingsPage.swift
Comment thread wire-ios/WireUITests/Pages/AccountSettingsPage.swift
Comment thread wire-ios/WireUITests/Pages/AccountSettingsPage.swift
Comment thread wire-ios/WireUITests/Pages/AccountSettingsPage.swift
Comment thread wire-ios/WireUITests/Pages/ActiveConversationPage.swift Outdated
@sonarqubecloud

Copy link
Copy Markdown

@samwyndham samwyndham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I think we should avoid having too many of these dynamic identifiers around the codebase as it can become hard to reason about. I wonder if we should consider adding image snapshot testing to our UI tests for such kinds of tests.

@findms findms requested review from caldrian and removed request for jullianm June 26, 2026 15:21
@findms findms enabled auto-merge July 6, 2026 07:01
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@findms findms added this pull request to the merge queue Jul 6, 2026
Merged via the queue into develop with commit 44d2ddb Jul 6, 2026
12 checks passed
@findms findms deleted the chore/ms-test-theme-color-image-tests branch July 6, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants