fix: prevent keyboard trap in input field - WPB-14697#4955
Conversation
acv-w
requested review from
a team,
caldrian and
netbe
and removed request for
a team
Test Results1 936 tests 1 909 ✅ 2m 32s ⏱️ Results for commit dc83851. ♻️ This comment has been updated with latest results. Summary: workflow run #28660131583 |
David-Henner
left a comment
David-Henner
left a comment
There was a problem hiding this comment.
how does this behave with VoiceOver on?
| argument: ([sendButton, ephemeralIndicatorButton] + inputBar.buttonsView.buttons) | ||
| .first { !$0.isHidden && $0.isEnabled && $0.isUserInteractionEnabled && $0.alpha > 0 } |
There was a problem hiding this comment.
question: what does this do ?
There was a problem hiding this comment.
This basically moves the AX/VoiceOver focus to the next element. It's a nicety I figured we should add. If we want to be strict I can remove it.
There was a problem hiding this comment.
how does this behave with VoiceOver on?
It doesn't really have anything to do with VoiceOver. It will resign on tab, regardless of the VoiceOver status.
There was a problem hiding this comment.
question: how do you tab on iOS?
There was a problem hiding this comment.
In this context I was referring to the "next element" / "previous element" gesture in VoiceOver.
|
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
left a question before approving
3 participants
Issue
Prevents Tab from being inserted into the message composer by resigning the input field and moving VoiceOver focus to the next available composer control. This removes the keyboard trap.
Testing
Compose a message, press Tab, input will be dismissed.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: