wip: extended test

Author: battermann

integration/test/Test/MLS/History.hs

@@ -152,7 +152,10 @@ testHistoryConflict = do
   -- adding an empty commit to be able to test application message rejection
   void $ createPendingProposalCommit convId alice1 >>= sendAndConsumeCommitBundle
 
-  -- HISTORY ENABLED
+  -- a history client cannot be added if shared history is disabled
+  assertAddHistoryClientRejected convId alice1
+
+  -- SHARED HISTORY ENABLED
   enableHistorySharing convId alice
 
   -- application message and add commit are rejected
@@ -165,24 +168,45 @@ testHistoryConflict = do
     void $ sendAndConsumeCommitBundle mp
     pure hid
 
+  -- it is not possible to add more than 1 history client
+  assertAddHistoryClientRejected convId alice1
+
   -- application message and add commits are accepted
   void $ createApplicationMessage convId alice1 "hello" >>= sendAndConsumeMessage
   void $ createAddCommit alice1 convId [charlie] >>= sendAndConsumeCommitBundle
 
-  -- HISTORY DISABLED
+  -- SHARED HISTORY DISABLED
   disableHistorySharing convId alice
 
-  -- application message and add commit are rejected
+  -- application message and add commit, as well as history client requests are rejected
   assertApplicationMessageFailure convId alice1
   assertAddCommitIsRejected convId alice1 [dorothy]
+  assertAddHistoryClientRejected convId alice1
 
   -- HISTORY CLIENT REMOVED
   void $ createRemoveCommit' alice1 convId [HistoryClient hid] >>= sendAndConsumeCommitBundle
 
   -- application message and add commits are accepted
   void $ createApplicationMessage convId alice1 "hello" >>= sendAndConsumeMessage
   void $ createAddCommit alice1 convId [emily] >>= sendAndConsumeCommitBundle
+
+  -- a history client cannot be added if shared history is disabled
+  assertAddHistoryClientRejected convId alice1
   where
+    assertAddHistoryClientRejected :: (HasCallStack) => ConvId -> ClientIdentity -> App ()
+    assertAddHistoryClientRejected convId user = do
+      mp <- fst <$> createAddCommitWithHistoryClient user convId []
+      postMLSCommitBundle mp.sender (mkBundle mp) `bindResponse` \resp -> do
+        resp.status `shouldMatchInt` 400
+        resp.json %. "label" `shouldMatch` "mls-history-client-conflict"
+
+    -- assertAddHistoryClientFailure :: (HasCallStack) => ConvId -> ClientIdentity -> App ()
+    -- assertAddHistoryClientFailure convId user = do
+    --   mp <- fst <$> createAddCommitWithHistoryClient user convId []
+    --   postMLSCommitBundle mp.sender (mkBundle mp) `bindResponse` \resp -> do
+    --     resp.status `shouldMatchInt` 400
+    --     resp.json %. "label" `shouldMatch` "mls-history-client-conflict"
+
     assertAddCommitIsRejected :: (HasCallStack) => ConvId -> ClientIdentity -> [Value] -> App ()
     assertAddCommitIsRejected convId user users =
       withMLSStateReset $ do