feat: expose enabled startup feature toggle names via getter property

Author: screendriver

apps/webapp/src/script/featureToggles/startupFeatureToggleQueryParameters.ts

@@ -43,7 +43,7 @@ function readEnabledFeatureToggleNameSetFromLocationSearch(
   locationSearch: string,
 ): ReadonlySet<StartupFeatureToggleName> {
   const startupFeatureToggles = createStartupFeatureTogglesFromLocationSearch(locationSearch);
-  return new Set(startupFeatureToggles.getEnabledFeatureToggleNames());
+  return new Set(startupFeatureToggles.enabledFeatureToggleNames);
 }
 
 function toUpdatedEnabledFeatureToggleNameSet(

apps/webapp/src/script/featureToggles/startupFeatureToggles.test.ts

@@ -40,7 +40,7 @@ describe('startupFeatureToggles', function () {
     const startupFeatureToggles = createStartupFeatureTogglesFromLocationSearch('?foo=bar');
 
     expect(startupFeatureToggles.isFeatureToggleEnabled(reliableWebsocketConnectionFeatureToggleName)).toBe(false);
-    expect(startupFeatureToggles.getEnabledFeatureToggleNames()).toEqual([]);
+    expect(startupFeatureToggles.enabledFeatureToggleNames).toEqual([]);
   });
 
   it('enables a whitelisted feature toggle when present in the query parameter', () => {
@@ -57,15 +57,15 @@ describe('startupFeatureToggles', function () {
     );
 
     expect(startupFeatureToggles.isFeatureToggleEnabled(reliableWebsocketConnectionFeatureToggleName)).toBe(true);
-    expect(startupFeatureToggles.getEnabledFeatureToggleNames()).not.toContain('unknown-feature');
+    expect(startupFeatureToggles.enabledFeatureToggleNames).not.toContain('unknown-feature');
   });
 
   it('ignores unknown feature toggles from the query parameter', () => {
     const startupFeatureToggles = createStartupFeatureTogglesFromLocationSearch(
       `?${startupFeatureToggleQueryParameterName}=unknown-feature`,
     );
 
-    expect(startupFeatureToggles.getEnabledFeatureToggleNames()).toEqual([]);
+    expect(startupFeatureToggles.enabledFeatureToggleNames).toEqual([]);
   });
 
   it('keeps only whitelisted feature toggles when known and unknown values are mixed', () => {
@@ -74,7 +74,7 @@ describe('startupFeatureToggles', function () {
     );
 
     expect(startupFeatureToggles.isFeatureToggleEnabled(reliableWebsocketConnectionFeatureToggleName)).toBe(true);
-    expect(startupFeatureToggles.getEnabledFeatureToggleNames()).not.toContain('unknown-feature');
+    expect(startupFeatureToggles.enabledFeatureToggleNames).not.toContain('unknown-feature');
   });
 
   it('enables the applock refactored feature toggle when present in the query parameter', () => {
@@ -107,9 +107,7 @@ describe('startupFeatureToggles', function () {
     );
 
     expect(startupFeatureToggles.isFeatureToggleEnabled(reliableWebsocketConnectionFeatureToggleName)).toBe(true);
-    expect(startupFeatureToggles.getEnabledFeatureToggleNames()).toEqual([
-      reliableWebsocketConnectionFeatureToggleName,
-    ]);
+    expect(startupFeatureToggles.enabledFeatureToggleNames).toEqual([reliableWebsocketConnectionFeatureToggleName]);
   });
 
   it('ignores empty list entries in the feature toggle query parameter', () => {
@@ -118,9 +116,7 @@ describe('startupFeatureToggles', function () {
     );
 
     expect(startupFeatureToggles.isFeatureToggleEnabled(reliableWebsocketConnectionFeatureToggleName)).toBe(true);
-    expect(startupFeatureToggles.getEnabledFeatureToggleNames()).toEqual([
-      reliableWebsocketConnectionFeatureToggleName,
-    ]);
+    expect(startupFeatureToggles.enabledFeatureToggleNames).toEqual([reliableWebsocketConnectionFeatureToggleName]);
   });
 
   it('treats feature toggle names as case-sensitive', () => {
@@ -130,7 +126,7 @@ describe('startupFeatureToggles', function () {
     );
 
     expect(startupFeatureToggles.isFeatureToggleEnabled(reliableWebsocketConnectionFeatureToggleName)).toBe(false);
-    expect(startupFeatureToggles.getEnabledFeatureToggleNames()).not.toContain(uppercaseFeatureToggleName);
+    expect(startupFeatureToggles.enabledFeatureToggleNames).not.toContain(uppercaseFeatureToggleName);
   });
 
   it('contains only whitelisted values in allowedStartupFeatureToggleNames', () => {

apps/webapp/src/script/featureToggles/startupFeatureToggles.ts

@@ -30,7 +30,7 @@ const allowedStartupFeatureToggleNameSet = new Set<StartupFeatureToggleName>(all
 
 export type StartupFeatureToggles = {
   readonly isFeatureToggleEnabled: (featureToggleName: StartupFeatureToggleName) => boolean;
-  readonly getEnabledFeatureToggleNames: () => readonly StartupFeatureToggleName[];
+  readonly enabledFeatureToggleNames: readonly StartupFeatureToggleName[];
 };
 
 function trimFeatureToggleName(featureToggleName: string): string {
@@ -68,11 +68,11 @@ export function createStartupFeatureTogglesFromLocationSearch(locationSearch: st
   );
 
   return {
-    isFeatureToggleEnabled: function isFeatureToggleEnabled(featureToggleName: StartupFeatureToggleName): boolean {
+    isFeatureToggleEnabled(featureToggleName) {
       return enabledFeatureToggleNameSet.has(featureToggleName);
     },
 
-    getEnabledFeatureToggleNames: function getEnabledFeatureToggleNames(): readonly StartupFeatureToggleName[] {
+    get enabledFeatureToggleNames() {
       return [...enabledFeatureToggleNameSet];
     },
   };