feat: add option to disable message preprocessing in the internal appconfiguration#21275
Open
MohamadJaara wants to merge 1 commit into
Open
feat: add option to disable message preprocessing in the internal appconfiguration#21275MohamadJaara wants to merge 1 commit into
MohamadJaara wants to merge 1 commit into
Conversation
MohamadJaara
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
MohamadJaara
force-pushed
the
mo/feat/add-option-to-disable-message-preprocessing
branch
from
4cd860a to
5f5ffc7
Compare
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 0 failed,
|
zskhan
reviewed
May 15, 2026
|
|
||
| const renderMessagePreprocessingSwitch = () => { | ||
| return ( | ||
| <div style={{marginBottom: '10px'}}> |
Contributor
There was a problem hiding this comment.
We can move the CSS to configToolbar.styles.ts
| {!disableMessagePreprocessing && ( | ||
| <PastePlugin getMentionCandidates={getMentionCandidates} isPreviewMode={showMarkdownPreview} /> | ||
| )} | ||
| {disableMessagePreprocessing && <PlainTextPastePlugin />} |
Contributor
There was a problem hiding this comment.
Suggested change
| {disableMessagePreprocessing && <PlainTextPastePlugin />} | |
| {disableMessagePreprocessing ? (<PlainTextPastePlugin />) : ( | |
| <PastePlugin getMentionCandidates={getMentionCandidates} isPreviewMode={showMarkdownPreview} /> | |
| )} |
|
|
||
| useEffect(() => { | ||
| const handleMessagePreprocessingChange = (event: Event) => { | ||
| setDisableMessagePreprocessing((event as CustomEvent<boolean>).detail ?? isMessagePreprocessingDisabled()); |
Contributor
There was a problem hiding this comment.
Suggested change
| setDisableMessagePreprocessing((event as CustomEvent<boolean>).detail ?? isMessagePreprocessingDisabled()); | |
| const isDisabled = | |
| event instanceof CustomEvent && is.boolean(event.detail) | |
| ? event.detail | |
| : isMessagePreprocessingDisabled(); | |
| setDisableMessagePreprocessing(isDisabled); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an internal developer-menu flag to disable message preprocessing and markdown preview behavior in the composer.
The current preprocessing can alter messages in ways that make composing feel unpredictable, especially when typing or pasting exact text/code or URLs. This flag is a temporary bandage so messages can be sent closer to what was typed while we sort out the underlying composer/preprocessing behavior properly.
Notes