Make boolean checks explicit without changing how the app behaves [WPB-22420]#21292
Draft
screendriver wants to merge 1 commit into
Draft
Make boolean checks explicit without changing how the app behaves [WPB-22420]#21292screendriver wants to merge 1 commit into
screendriver wants to merge 1 commit into
Conversation
screendriver
changed the title
zskhan
reviewed
May 12, 2026
| const lookup = await maxmind.open<CountryResponse>(countryDatabasePath); | ||
| const result = lookup.get(ipAddress); | ||
| if (result) { | ||
| if (result !== undefined && result !== null) { |
Contributor
There was a problem hiding this comment.
Can we use @sindresorhus/is here?
Suggested change
| if (result !== undefined && result !== null) { | |
| if (!is.nullOrUndefined(result)) { |
screendriver
force-pushed
the
null-undefined
branch
from
2803f1d to
61d92ac
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes our code stricter and easier to reason about by removing implicit truthy/falsy checks