fix(core): skip conference MLS decrypt while leaving a call [WPB-24984]#21353
Open
thisisamir98 wants to merge 1 commit into
Open
fix(core): skip conference MLS decrypt while leaving a call [WPB-24984]#21353thisisamir98 wants to merge 1 commit into
thisisamir98 wants to merge 1 commit into
Conversation
Problem: When a user hangs up, leaveConferenceSubconversation wipes the conference MLS group in core-crypto, but queued conversation.mls-message-add events for that subconv can still be handled moments later. Decrypting them then fails with MlsErrorOther "Couldn't find conversation" and spams error logs. Solution: Track parents that are tearing down the conference subconv and return null from handleMLSMessageAddEvent for conference message-add events during that window, so we never call core-crypto for decrypt. Clear the flag on join and in a finally block after leave completes.
thisisamir98
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver and
zskhan
as code owners
thisisamir98
changed the title
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When a user hangs up, leaveConferenceSubconversation wipes the conference MLS group in core-crypto, but queued conversation.mls-message-add events for that subconv can still be handled moments later. Decrypting them then fails with MlsErrorOther "Couldn't find conversation" and spams error logs.
Solution: Track parents that are tearing down the conference subconv and return null from handleMLSMessageAddEvent for conference message-add events during that window, so we never call core-crypto for decrypt. Clear the flag on join and in a finally block after leave completes.