feat/1421 addressing PR comments - Updated logic to represent IsDisable insted of IsEnabled

Author: jayaraman-venkatesan

src/WireMock.Net.Abstractions/Admin/Mappings/MappingModel.cs

@@ -62,9 +62,9 @@ public class MappingModel
     public int? TimesInSameState { get; set; }
 
     /// <summary>
-    /// Value to determing if the mapping is active
+    /// Value to determine if the mapping is disabled. Defaults to <c>null</c> (not disabled).
     /// </summary>
-    public bool? IsEnabled { get; set; }
+    public bool? IsDisabled { get; set; }
 
     /// <summary>
     /// The request model.

src/WireMock.Net.Minimal/Mapping.cs

@@ -63,7 +63,7 @@ public class Mapping : IMapping
     public bool IsProxy => Provider is ProxyAsyncResponseProvider;
 
     /// <inheritdoc />
-    public bool IsEnabled { get; set; } = true;
+    public bool IsDisabled { get; set; }
 
     /// <inheritdoc />
     public bool LogMapping => Provider is not (DynamicResponseProvider or DynamicAsyncResponseProvider);

src/WireMock.Net.Minimal/Owin/MappingMatcher.cs

@@ -19,7 +19,7 @@ internal class MappingMatcher(IWireMockMiddlewareOptions options, IRandomizerDou
         var possibleMappings = new List<MappingMatcherResult>();
 
         var mappings = _options.Mappings.Values
-            .Where(m=>m.IsEnabled)
+            .Where(m => !m.IsDisabled)
             .Where(m => m.TimeSettings.IsValid())
             .Where(m => m.Probability is null || _randomizerDoubleBetween0And1.Generate() <= m.Probability)
             .ToArray();

src/WireMock.Net.Minimal/Serialization/MappingConverter.cs

@@ -275,7 +275,7 @@ public MappingModel ToMappingModel(IMapping mapping)
             TimesInSameState = !string.IsNullOrWhiteSpace(mapping.NextState) ? mapping.TimesInSameState : null,
             Data = mapping.Data,
             Probability = mapping.Probability,
-            IsEnabled = mapping.IsEnabled ? null : false,
+            IsDisabled = mapping.IsDisabled ? true : null,
             Request = new RequestModel
             {
                 Headers = headerMatchers.Any() ? headerMatchers.Select(hm => new HeaderModel

src/WireMock.Net.Minimal/Server/IRespondWithAProvider.cs

@@ -235,11 +235,11 @@ IRespondWithAProvider WithWebhook(
     IRespondWithAProvider WithProbability(double probability);
 
     /// <summary>
-    /// Define whether this mapping is enabled. Defaults to <c>true</c>.
+    /// Define whether this mapping is disabled. Defaults to <c>false</c>.
     /// </summary>
-    /// <param name="isEnabled">Whether this mapping is enabled.</param>
+    /// <param name="isDisabled">Whether this mapping is disabled.</param>
     /// <returns>The <see cref="IRespondWithAProvider"/>.</returns>
-    IRespondWithAProvider WithIsEnabled(bool isEnabled);
+    IRespondWithAProvider WithIsDisabled(bool isDisabled);
 
     /// <summary>
     /// Define a Grpc ProtoDefinition which is used for the request and the response.

src/WireMock.Net.Minimal/Server/RespondWithAProvider.cs

@@ -37,7 +37,7 @@ internal class RespondWithAProvider : IRespondWithAProvider
     private int _timesInSameState = 1;
     private bool? _useWebhookFireAndForget;
     private double? _probability;
-    private bool _isEnabled = true;
+    private bool _isDisabled = false;
     private GraphQLSchemaDetails? _graphQLSchemaDetails; // Future Use.
 
     public Guid Guid { get; private set; }
@@ -109,9 +109,9 @@ public void RespondWith(IResponseProvider provider)
             mapping.WithProbability(_probability.Value);
         }
 
-        if (!_isEnabled)
+        if (_isDisabled)
         {
-            mapping.IsEnabled = false;
+            mapping.IsDisabled = true;
         }
 
         if (ProtoDefinition != null)
@@ -361,9 +361,9 @@ public IRespondWithAProvider WithProbability(double probability)
     }
 
     /// <inheritdoc />
-    public IRespondWithAProvider WithIsEnabled(bool isEnabled)
+    public IRespondWithAProvider WithIsDisabled(bool isDisabled)
     {
-        _isEnabled = isEnabled;
+        _isDisabled = isDisabled;
         return this;
     }
 

src/WireMock.Net.Minimal/Server/WireMockServer.Admin.cs

@@ -451,7 +451,7 @@ private IResponseMessage MappingEnable(HttpContext _, IRequestMessage requestMes
             var mapping = Mappings.FirstOrDefault(m => !m.IsAdminInterface && m.Guid == guid);
             if (mapping != null)
             {
-                mapping.IsEnabled = true;
+                mapping.IsDisabled = false;
                 return ResponseMessageBuilder.Create(HttpStatusCode.OK, "Mapping enabled", guid);
             }
         }
@@ -467,7 +467,7 @@ private IResponseMessage MappingDisable(HttpContext _, IRequestMessage requestMe
             var mapping = Mappings.FirstOrDefault(m => !m.IsAdminInterface && m.Guid == guid);
             if (mapping != null)
             {
-                mapping.IsEnabled = false;
+                mapping.IsDisabled = true;
                 return ResponseMessageBuilder.Create(HttpStatusCode.OK, "Mapping disabled", guid);
             }
         }

src/WireMock.Net.Minimal/Server/WireMockServer.ConvertMapping.cs

@@ -120,9 +120,9 @@ private Guid ConvertMappingAndRegisterAsRespondProvider(MappingModel mappingMode
             respondProvider.WithProbability(mappingModel.Probability.Value);
         }
 
-        if (mappingModel.IsEnabled == false)
+        if (mappingModel.IsDisabled == true)
         {
-            respondProvider.WithIsEnabled(false);
+            respondProvider.WithIsDisabled(true);
         }
 
         // ProtoDefinition is defined at Mapping level

src/WireMock.Net.Shared/IMapping.cs

@@ -109,12 +109,12 @@ public interface IMapping
     bool IsProxy { get; }
 
     /// <summary>
-    /// Gets a value indicating whether this mapping is a Proxy Mapping.
+    /// Gets a value indicating whether this mapping is disabled.
     /// </summary>
     /// <value>
-    /// <c>true</c> if this mapping is a Proxy Mapping; otherwise, <c>false</c>.
+    /// <c>true</c> if this mapping is disabled; otherwise, <c>false</c>.
     /// </value>
-    bool IsEnabled { get; set; }
+    bool IsDisabled { get; set; }
 
     /// <summary>
     /// Gets a value indicating whether this mapping to be logged.

…inApi/WireMockAdminApiTests.IsEnabled.cs …nApi/WireMockAdminApiTests.IsDisabled.cstest/WireMock.Net.Tests/AdminApi/WireMockAdminApiTests.IsEnabled.cs renamed to test/WireMock.Net.Tests/AdminApi/WireMockAdminApiTests.IsDisabled.cs test/WireMock.Net.Tests/AdminApi/WireMockAdminApiTests.IsEnabled.cs renamed to test/WireMock.Net.Tests/AdminApi/WireMockAdminApiTests.IsDisabled.cs

@@ -10,7 +10,7 @@ namespace WireMock.Net.Tests.AdminApi;
 public partial class WireMockAdminApiTests
 {
     [Fact]
-    public async Task IWireMockAdminApi_PostMappingAsync_WithIsEnabledFalse_DoesNotMatchRequests()
+    public async Task IWireMockAdminApi_PostMappingAsync_WithIsDisabledTrue_DoesNotMatchRequests()
     {
         // Arrange
         var ct = TestContext.Current.CancellationToken;
@@ -22,7 +22,7 @@ public async Task IWireMockAdminApi_PostMappingAsync_WithIsEnabledFalse_DoesNotM
         {
             Request = new RequestModel { Path = "/foo", Methods = ["GET"] },
             Response = new ResponseModel { Body = "hello", StatusCode = 200 },
-            IsEnabled = false
+            IsDisabled = true
         };
 
         // Act — POST the disabled mapping
@@ -33,8 +33,8 @@ public async Task IWireMockAdminApi_PostMappingAsync_WithIsEnabledFalse_DoesNotM
         var response = await httpClient.GetAsync("/foo", ct);
         ((int)response.StatusCode).Should().Be(404);
 
-        // Assert — mapping exists but IsEnabled is false
-        server.Mappings.Where(m => !m.IsAdminInterface).Should().ContainSingle(m => m.IsEnabled == false);
+        // Assert — mapping exists but IsDisabled is true
+        server.Mappings.Where(m => !m.IsAdminInterface).Should().ContainSingle(m => m.IsDisabled == true);
     }
 
     [Fact]
@@ -80,7 +80,7 @@ public async Task IWireMockAdminApi_EnableMappingAsync_ResumesMatching()
         {
             Request = new RequestModel { Path = "/baz", Methods = ["GET"] },
             Response = new ResponseModel { Body = "re-enabled", StatusCode = 200 },
-            IsEnabled = false
+            IsDisabled = true
         };
         var postResult = await api.PostMappingAsync(model, ct);
         var guid = postResult.Guid!.Value;
@@ -99,7 +99,7 @@ public async Task IWireMockAdminApi_EnableMappingAsync_ResumesMatching()
     }
 
     [Fact]
-    public async Task IWireMockAdminApi_GetMappingAsync_ReturnsIsEnabledFalse_WhenDisabled()
+    public async Task IWireMockAdminApi_GetMappingAsync_ReturnsIsDisabledTrue_WhenDisabled()
     {
         // Arrange
         var ct = TestContext.Current.CancellationToken;
@@ -110,7 +110,7 @@ public async Task IWireMockAdminApi_GetMappingAsync_ReturnsIsEnabledFalse_WhenDi
         {
             Request = new RequestModel { Path = "/check-disabled" },
             Response = new ResponseModel { Body = "x", StatusCode = 200 },
-            IsEnabled = false
+            IsDisabled = true
         };
         var enabledModel = new MappingModel
         {
@@ -125,10 +125,10 @@ public async Task IWireMockAdminApi_GetMappingAsync_ReturnsIsEnabledFalse_WhenDi
         var disabledGot = await api.GetMappingAsync(disabledPost.Guid!.Value, ct);
         var enabledGot = await api.GetMappingAsync(enabledPost.Guid!.Value, ct);
 
-        // Assert — disabled mapping serializes IsEnabled = false
-        disabledGot.IsEnabled.Should().BeFalse();
+        // Assert — disabled mapping serializes IsDisabled = true
+        disabledGot.IsDisabled.Should().BeTrue();
 
-        // Assert — enabled mapping omits IsEnabled (null = default true)
-        enabledGot.IsEnabled.Should().BeNull();
+        // Assert — enabled mapping omits IsDisabled (null = default not disabled)
+        enabledGot.IsDisabled.Should().BeNull();
     }
 }