Skip to content

Update release drafter & CI workflows to latest versions#26

Merged
oleg-nenashev merged 3 commits into
wiremock:mainfrom
aaravmahajanofficial:chore/update-github-actions-workflows
Sep 2, 2025
Merged

Update release drafter & CI workflows to latest versions#26
oleg-nenashev merged 3 commits into
wiremock:mainfrom
aaravmahajanofficial:chore/update-github-actions-workflows

Conversation

@aaravmahajanofficial
Copy link
Copy Markdown
Contributor

Updated the workflows to latest versions. Removed the "Validate Gradle Wrapper" step, as starting with v4 setup-gradle action, validation automatically runs on each execution :)

Ref: https://github.com/gradle/actions?tab=readme-ov-file#the-wrapper-validation-action

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oleg-nenashev oleg-nenashev added the chore Maintenance label Aug 14, 2025
@oleg-nenashev oleg-nenashev changed the title chore: update release drafter & CI workflows to latest versions Update release drafter & CI workflows to latest versions Aug 14, 2025
Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaravmahajanofficial Thanks for the patch, but another minor update is needed

The 'arguments' parameter is no longer supported for gradle/actions/setup-gradle.

@aaravmahajanofficial
Copy link
Copy Markdown
Contributor Author

@oleg-nenashev, Removed the "arguments" from the ci.yml, added a separate build step instead. Updated the gradle from 8.10.1 to 8.14.3; added a foojay-resolver plugin to resolve the issue with JDK not installed error

Comment thread .github/workflows/ci.yml Outdated
@oleg-nenashev
Copy link
Copy Markdown
Member

I switched the CI to Java 17. I am not sure it is a good idea, but Java version should be rather passed to Gradle through the tool chain as you have already started modifying towards it

I will check whether we still even want Java 11...

Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current configuration, the build itself will still happen with Java 11 toolchain as defined in the Gradle build.

We will be able to fuly switch to Java 17 with https://wiremock.org/docs/download-and-installation/#4x-beta-release-downloads . As for now, I will go ahead and merge the PR as I want to resolve Maven Central releases on the top of it

@oleg-nenashev oleg-nenashev merged commit 3035433 into wiremock:main Sep 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants