Prepare v0.4 release#338
Closed
17o2 wants to merge 92 commits into
Closed
Conversation
`.gv` and `.html` files include the version number as a comment. Rebuild to avoid diffs during development
Moved metadata and options info further down, so that the core functionality (connectors, cables, connection sets) comes first.
- Use pin names instead of pin indices, until the last moment when generating the ports for the GraphViz nodes - `Harness.add_mate_pin()` now uses pin names - Remove unused `if is_arrow()` check from `Harness.connect()` - Consolidate calling of `Connector.activate_pin()` to prevent subtle bugs - Call it from `connect()` and `add_mate_pin()` - No longer call it from `create_graph()` - Misc. other tuning
Co-authored-by: kvid <kvid@users.noreply.github.com>
Co-authored-by: kvid <kvid@users.noreply.github.com>
Co-authored-by: kvid <kvid@users.noreply.github.com>
Co-authored-by: kvid <kvid@users.noreply.github.com>
Experiments in exporting PDF using `wkhtmltopdf` utility caused borders to disappear when set to 0.25mm, but 0.35mm renders fine
Re-add `parse_file()` for building examples bla
The two header comments were missing trailing newlines. This behavior is introduced by v0.18 of the graphviz Python package; where as v0.17 did include the newline automatically. Closes #258
Changes in #186 made it impossible to hide cable wire numbers. #186 (comment)
Hard-coding OS error numbers that differ between different platforms caused the program to crash at platforms using a different error number. Using the Standard errno system symbols will avoid this problem. Co-authored-by: kvid <kvid@users.noreply.github.com>
- Resolves #263 that describes warnings and weird loop drawing because loop connected pins are hidden when hide_disconnected_pins=True. - Activate loop pins as early as possible to enable correct counting of connected pins when connector.additional_components.qty_multiplier=populated. - Check that loop pins actually exist before activating them.
No need to reference github issue in the code. Co-authored-by: Daniel Rojas <github@danielrojas.net>
Add two more folders to be ignored. - .idea: Used by PyCharm - .venv: My convention for creating virtualenvs
Co-authored-by: kvid <kvid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #339 instead.