fix(astro): preserve quoted import specifiers when appending asset query params#16207
Closed
auroursa wants to merge 2 commits into
Closed
fix(astro): preserve quoted import specifiers when appending asset query params#16207auroursa wants to merge 2 commits into
auroursa wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: c6b3ff4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
When will this patch be released ? |
briandadams85
added a commit
to BrianDAdamsDevland/bdadamsdotcom
that referenced
this pull request
Apr 11, 2026
Astro 6.1.3 introduced a bug (withastro/astro#16196, #16209) in the pluginChunkImports plugin that corrupts dynamic import specifiers on Netlify/Linux builds when DEPLOY_ID is set. This causes esbuild to fail with syntax errors on unresolved Rollup hash placeholders. The fix (withastro/astro#16207) has not been released yet. Pinning to 6.1.2 avoids the regression and removes the minification workaround. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Eagerly waiting for this fix. Netlify builds are failing in the meantime. |
Member
|
I fixed it in another PR |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16196
This seems likely connected to #16110, which introduced inter-chunk import rewriting for adapter asset query params.
Deployment Failure on Netlify
Changes
plugin-chunk-importsrewrite logic to preserve valid JS import syntax when appendingassetQueryParams.es-module-lexeroffsets, instead of inserting blindly at the previous end offset.?queryand#hashin relative inter-chunk JS imports._astro/*.jscould become syntactically invalid in downstream bundling.Testing
_astro/*.jschunks).