feat: add markdown processor abstraction#16848
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 62f090e The changes in this PR will be included in the next version bump. This PR includes changesets to release 418 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
semver: minor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Princesseuh
commented
May 23, 2026
| try { | ||
| const decodedImagePath = JSON.parse(imagePath.replaceAll('"', '"')); | ||
| const decodedImagePath = JSON.parse( | ||
| imagePath.replace(/&(?:#x22|quot);/g, '"').replace(/&(?:#x27|apos);/g, "'"), |
Member
Author
There was a problem hiding this comment.
Remark (somewhat unusually) uses numerical entities instead of named ones, other Markdown processors are more likely to use named entities.
Princesseuh
commented
May 23, 2026
| * falls back to its built-in handling for the known `unified` processor name. | ||
| * Third-party processors should provide this to enable MDX support. | ||
| */ | ||
| createMdxRenderer?( |
Member
Author
There was a problem hiding this comment.
MDX code in core, looks weird, but it's more likely than you think. Ever since we added MDX Astro has had some sort of MDX-specific layer somewhere. At this point, I find it doubtful we'd ever be dropping MDX support and so I figured this was the best API
(and down the line I'd like for the first party processors to also use that API, but it's a bigger conversation of making MDX fully built-in, ha)
Member
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
I left a few nits for the configuration reference, and I think the changeset should be a bit more verbose both to hype the feature and to show that Sätteri is also available! If we don't tell users Sätteri exists, they will not try it. 😅
matthewp
approved these changes
May 23, 2026
…or<T> Replace `MarkdownProcessorEntry` + `UnifiedProcessorDescriptor` with a single generic `MarkdownProcessor<TOptions>` interface, and rename the renderer to `MarkdownRenderer` so the two concepts have separate nouns. Move the MDX renderer types (`MdxRenderer`, `MdxRendererOptions`, `MdxRenderResult`) into `@astrojs/internal-helpers/markdown` so they can be referenced by processor packages without astro re-entering the dep graph. Also relaxes the over-narrow `AstroMetadata` shape (`scripts: never[]`, `propagation: 'none'`, …) so the unified MDX pipeline's compiler-produced metadata fits the same type the satteri pipeline produces.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
ArmandPhilippot
approved these changes
May 25, 2026
Princesseuh
commented
May 26, 2026
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Contributor
|
| 📦 Package | 📏 Size |
|---|---|
| @napi-rs/wasm-runtime@1.1.4 | 6.3 MB |
| @bruits/satteri-linux-x64-gnu@0.6.3 | 3.1 MB |
| @emnapi/core@1.9.1 | 1.9 MB |
| @emnapi/runtime@1.9.1 | 424.1 kB |
| @emnapi/wasi-threads@1.2.0 | 227.6 kB |
| satteri@0.6.3 | 218.5 kB |
Total size change: 12.1 MB
Princesseuh
commented
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
markdown.processorpart of withastro/roadmap#1364, please see the RFC for details.Testing
Updated tests that relied on specific remark plugins and what not. Added tests using a custom processor to make sure it works from e2e
Docs
withastro/docs#13919