Skip to content

Add build.assetsPrefix to configuration reference#13834

Merged
ArmandPhilippot merged 2 commits into
mainfrom
rururux/add-build-assetsPrefix
May 14, 2026
Merged

Add build.assetsPrefix to configuration reference#13834
ArmandPhilippot merged 2 commits into
mainfrom
rururux/add-build-assetsPrefix

Conversation

@rururux

@rururux rururux commented May 5, 2026

Copy link
Copy Markdown
Member

Description (required)

Both the deprecation comments in Astro's source code and the "Deprecated: import.meta.env.ASSETS_PREFIX" section on the "Upgrade to Astro v6" page recommend importing build.assetsPrefix from astro:config/server as a replacement for import.meta.env.ASSETS_PREFIX.
However, build.assetsPrefix was missing from the "Imports from astro:config/server" reference.

This PR adds build.assetsPrefix to the "Imports from astro:config/server" list.

Related issues & labels (optional)

withastro/astro#16604
withastro/astro#16605

@netlify

netlify Bot commented May 5, 2026

Copy link
Copy Markdown

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 1877f07
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6a063a5bb7c50b0008ce6013
😎 Deploy Preview https://deploy-preview-13834--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston

astrobot-houston commented May 5, 2026

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/modules/astro-config.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@rururux rururux marked this pull request as draft May 5, 2026 10:12

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM! (even if this is still a draft) We can merge this when withastro/astro#16653 is merged.

@ArmandPhilippot ArmandPhilippot added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label May 13, 2026
@rururux

rururux commented May 14, 2026

Copy link
Copy Markdown
Member Author

Thank you for the approval!
I had kept this PR as a draft because I was waiting for the implementation PR to be merged, and now that both that and the release PR have been merged, this PR is ready to merge as well!

@rururux rururux marked this pull request as ready for review May 14, 2026 20:26
@ArmandPhilippot

Copy link
Copy Markdown
Member

This is not a big deal for this one as this is a small fix! But for your future docs contributions: it's better if you undraft the PR when it's ready. We have labels to be sure docs are not merged before the release.

A PR in draft means this is not yet ready for review so we usually don't check them. This could block a release: if the associated docs PRs do not have an approval, we may delay merging the [ci] release PR. We merge docs at the same time, not later. Users might check what is written in docs when they see a new release!

And feel free to merge your PRs once they are approved, you now have the right to do so! 😉

@ArmandPhilippot ArmandPhilippot merged commit 2845972 into main May 14, 2026
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the rururux/add-build-assetsPrefix branch May 14, 2026 21:19
@rururux

rururux commented May 14, 2026

Copy link
Copy Markdown
Member Author

Thanks for merging, and for the tips!
I'll keep that in mind for future PRs. 🙏

tarikrital pushed a commit to tarikrital/astro-docs that referenced this pull request Jul 6, 2026
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants