Skip to content

feat: document data store#14210

Open
ematipico wants to merge 4 commits into
mainfrom
feat/experimental-data-store
Open

feat: document data store#14210
ematipico wants to merge 4 commits into
mainfrom
feat/experimental-data-store

Conversation

@ematipico

@ematipico ematipico commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description (required)

Documentation for the new data store experimental feature

withastro/astro#17296

@ematipico ematipico mentioned this pull request Jul 7, 2026
Open
@astrobot-houston

astrobot-houston commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/data-store.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ematipico ematipico marked this pull request as ready for review July 7, 2026 15:35
@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

yanthomasdev
yanthomasdev reviewed Jul 7, 2026
View reviewed changes

@yanthomasdev yanthomasdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, @ematipico! A few initial suggestions from me.

Comment thread src/content/docs/en/reference/experimental-flags/data-store.mdx Outdated
Comment thread src/content/docs/en/reference/experimental-flags/data-store.mdx Outdated
Comment thread src/content/docs/en/reference/experimental-flags/data-store.mdx Outdated
Comment thread src/content/docs/en/reference/experimental-flags/data-store.mdx Outdated
Comment thread src/content/docs/en/reference/experimental-flags/data-store.mdx Outdated
Comment thread src/content/docs/en/reference/experimental-flags/data-store.mdx Outdated
ematipico and others added 3 commits July 8, 2026 14:00
@ematipico
chore: feedback
c83f9af
@ematipico
chore: feedback
e30523c
@ematipico @yanthomasdev
Apply suggestions from code review
dfcf9ce 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@ematipico ematipico requested a review from yanthomasdev July 8, 2026 13:18
ArmandPhilippot
ArmandPhilippot approved these changes Jul 8, 2026
View reviewed changes

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit regarding the filename/URL, otherwise LGTM. Thank you both!

Comment thread astro.sidebar.ts
'reference/experimental-flags/content-intellisense',
'reference/experimental-flags/chrome-devtools-workspace',
'reference/experimental-flags/svg-optimization',
'reference/experimental-flags/data-store',

@ArmandPhilippot ArmandPhilippot Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think usually the URL matches the flag name. Since this has been renamed, we probably should update this and the filename?

Suggested change
'reference/experimental-flags/data-store',
'reference/experimental-flags/collection-storage',

@ArmandPhilippot ArmandPhilippot added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Jul 8, 2026
@ArmandPhilippot ArmandPhilippot added this to the 7.1 milestone Jul 8, 2026
yanthomasdev
yanthomasdev approved these changes Jul 8, 2026
View reviewed changes

@yanthomasdev yanthomasdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Armand's nit is addressed, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes
@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ematipico @astrobot-houston @ArmandPhilippot @yanthomasdev