Skip to content

Commit 2da4af3

Browse files
Refactor migration to astro:config/client and update dependencies (#1584)
* refactor: migrate from 'virtual:studiocms/site' to 'astro:config/client' and update dependencies * chore: bump to Astro 6.1.0 and migrate back to astro:config virtual module
1 parent 9f4b1a1 commit 2da4af3

7 files changed

Lines changed: 11 additions & 14 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"studiocms": patch
3+
---
4+
5+
Bump to Astro 6.1.0 and migrate back to astro:config virtual module

packages/studiocms/src/client/apiClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { site } from 'virtual:studiocms/site';
1+
import { site } from 'astro:config/client';
22
import { FetchHttpClient, HttpApiClient } from '@effect/platform';
33
import type { HttpApi } from '@effect/platform/HttpApi';
44
import type { HttpApiGroup } from '@effect/platform/HttpApiGroup';

packages/studiocms/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,6 @@ export const studiocms = (): AstroIntegration => {
274274
addVirtualImports(params, {
275275
name,
276276
imports: {
277-
'virtual:studiocms/site': `export const site = "${config.site || 'http://localhost:4321'}";`,
278277
'studiocms:config': buildVirtualConfig(options),
279278
'studiocms:plugins': buildDefaultOnlyVirtual(safePluginList),
280279
'studiocms:version': buildDefaultOnlyVirtual(pkgVersion),

packages/studiocms/src/virtual.d.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
declare module 'virtual:studiocms/site' {
2-
// TODO: Migrate back to 'astro:config/client' once the upstream issue is resolved.
3-
// We should not need this... astro:config/client is importing server-side code that is extremely breaking. This is a temporary shim to get around that issue, but we should investigate the root cause and remove this.
4-
5-
export const site: string;
6-
}
7-
81
declare module 'studiocms:client/apiClients' {
92
export const authClient: typeof import('./client/apiClient').authClient;
103
export const dashboardClient: typeof import('./client/apiClient').dashboardClient;

packages/studiocms/src/virtuals/auth/verify-email.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1+
import { site } from 'astro:config/client';
12
import { StudioCMSRoutes } from 'studiocms:lib';
23
import { Mailer } from 'studiocms:mailer';
34
import { SDKCoreJs as sdk } from 'studiocms:sdk';
45
import type { CombinedUserData } from 'studiocms:sdk/types';
56
import templateEngine from 'studiocms:template-engine';
6-
import { site } from 'virtual:studiocms/site';
77
import { CMSNotificationSettingsId } from '../../consts.js';
88
import { Data, Effect, genLogger, pipeLogger } from '../../effect.js';
99
import type { UserSessionData } from './types.js';

pnpm-lock.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ catalogs:
5656
astrojs-current:
5757
"@astrojs/node": ^10.0.0
5858
"@astrojs/rss": ^4.0.17
59-
astro: ^6.0.8
59+
astro: ^6.1.0
6060
vite: ^7.3.1
6161
zod: ^4.3.6
6262

6363
astrojs-min:
6464
"@astrojs/internal-helpers": ^0.7.5 || ^0.8.0
65-
astro: ^5.12.9 || ^6.0.0
65+
astro: ^5.12.9 || ^6.1.0
6666
vite: ^6.3.4 || ^7.3.0
6767
zod: ^4.3.6
6868

0 commit comments

Comments
 (0)