fix(bin): use tree-kill to kill dry-run subprocs

Author: guidiaz

package.json

@@ -80,6 +80,7 @@
 		"promise-poller": "^1.9.1",
 		"protobufjs": "^7.5.4",
 		"qrcode-terminal": "^0.12.0",
+		"tree-kill": "^1.2.2",
 		"secp256k1": "^5.0.1"
 	},
 	"devDependencies": {

pnpm-lock.yaml

@@ -6,6 +6,7 @@ import * as os from "node:os";
 import path from "node:path";
 import * as readline from "node:readline";
 import moment from "moment";
+import kill from "tree-kill"
 
 const require = createRequire(import.meta.url);
 const _TOOLKIT_RUN_TIMEOUT_MSECS = 30000;
@@ -140,16 +141,7 @@ export function cmd(timeout, ...commands) {
 			console.debug("=> Killing process tree with PID:", child.pid);
 			console.debug("   Command:", `${bin} ${args.join(" ")}`);
 			if (!child.pid) return;
-			try {
-				if (process.platform === "win32") {
-					spawn("taskkill", ["/PID", child.pid.toString(), "/T", "/F"]);
-				} else {
-					// kill entire process group
-					process.kill(child.pid, "SIGKILL");
-				}
-			} catch (err) {
-				console.debug("   Error:", err);
-			}
+			kill(child.pid, (err) => console.debug("   Error:", err))
 		};
 
 		const timer =
@@ -177,7 +169,7 @@ export function cmd(timeout, ...commands) {
 			if (finished) return;
 			finished = true;
 			if (timer) clearTimeout(timer);
-
+			
 			if (signal) {
 				killTree();
 				reject(new Error(`npx terminated by signal ${signal}`));
@@ -189,7 +181,6 @@ export function cmd(timeout, ...commands) {
 				reject(new Error(`npx failed with exit code ${code}\n${stderr}`));
 				return;
 			}
-
 			resolve(stdout);
 		});
 	});
@@ -562,25 +553,25 @@ export async function toolkitRun(settings, args) {
 		let stderr = "";
 		let finished = false;
 
-		const killTree = () => {
-			if (!child.pid) return;
-			try {
-				if (process.platform === "win32") {
-					spawn("taskkill", ["/PID", child.pid.toString(), "/T", "/F"]);
-				} else {
-					// kill entire process group
-					process.kill(child.pid, "SIGKILL");
-				}
-			} catch {}
-		};
+		// const killTree = () => {
+		// 	if (!child.pid) return;
+		// 	try {
+		// 		if (process.platform === "win32") {
+		// 			spawn("taskkill", ["/PID", child.pid.toString(), "/T", "/F"]);
+		// 		} else {
+		// 			// kill entire process group
+		// 			process.kill(child.pid, "SIGKILL");
+		// 		}
+		// 	} catch {}
+		// };
 
 		child.stdout.on("data", (d) => (stdout += d.toString()));
 		child.stderr.on("data", (d) => (stderr += d.toString()));
 
 		child.on("error", (err) => {
 			if (finished) return;
 			finished = true;
-			killTree();
+			// killTree();
 			reject(err);
 		});
 
@@ -589,13 +580,13 @@ export async function toolkitRun(settings, args) {
 			finished = true;
 
 			if (signal) {
-				killTree();
+				// killTree();
 				reject(new Error(`witnet_toolkit binary terminated by signal ${signal}`));
 				return;
 			}
 
 			if (code !== 0) {
-				killTree();
+				// killTree();
 				reject(new Error(`witnet_toolkit binary failed with exit code ${code}\n${stderr}`));
 				return;
 			}