Fix showSixWeeks page() using aligned span instead of /6 heuristic#2780
Open
Norcy wants to merge 1 commit intowix:masterfrom
Open
Fix showSixWeeks page() using aligned span instead of /6 heuristic#2780Norcy wants to merge 1 commit intowix:masterfrom
Norcy wants to merge 1 commit intowix:masterfrom
Conversation
Replace (daysBefore + monthLength) / 6 with week-aligned span check: extend by one week only when from.diffDays(to) + 1 < 42. Fixes extra 7th row (e.g. March 2026 with firstDay=1) and missing trailing next-month cells (e.g. May 2026 staying at 5 weeks). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
showSixWeeksis true,page()used(daysBefore + monthLength) / 6 >= 6to decide whether to extendtoby 7 days. This does not match the real week-aligned cell count and caused:firstDay=1).Solution
After aligning
fromandtoto week boundaries, extend by one week only whenfrom.diffDays(to) + 1 < 42. Remove the/6heuristic and the unuseddaysBeforevariable.Testing
yarn test src/dateutils.spec.jsMade with Cursor