Merge pull request #1 from OneAboveAll1964/fix-android-app-crash-on-start

fix(android): prevent NullPointerException crashes during setRoot when activity is destroyed

Author: OneAboveAll1964

android/src/main/java/com/reactnativenavigation/react/NavigationTurboModule.kt

@@ -32,6 +32,14 @@ class NavigationTurboModule(
     private lateinit var eventEmitter: EventEmitter
 
     init {
+        activity()?.let { act ->
+            act.navigator?.let { nav ->
+                eventEmitter = EventEmitter(reactContext)
+                layoutFactory.init(act, eventEmitter, nav.childRegistry,
+                    (reactApplicationContext.applicationContext as NavigationApplication).externalComponents)
+            }
+        }
+
         reactContext.addLifecycleEventListener(object : LifecycleEventListenerAdapter() {
             override fun onHostPause() {
                 super.onHostPause()
@@ -83,12 +91,12 @@ class NavigationTurboModule(
         )
         handle {
             Log.d("NavigationTurboModule", "setRoot handle ${Thread.currentThread()}")
-            val viewController = layoutFactory.create(layoutTree)
             val activity = currentActivity
             if (activity == null) {
                 promise.reject("ACTIVITY_NULL", "Activity is null")
                 return@handle
             }
+            val viewController = layoutFactory.create(layoutTree)
             navigator()?.setRoot(
                 viewController,
                 NativeCommandListener("setRoot", commandId, promise, eventEmitter, now)

android/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/RootPresenter.java

@@ -35,11 +35,11 @@ public RootPresenter(RootAnimator animator, LayoutDirectionApplier layoutDirecti
     }
 
     public void setRoot(ViewController appearingRoot, ViewController<?> disappearingRoot, Options defaultOptions, CommandListener listener) {
-        layoutDirectionApplier.apply(appearingRoot, defaultOptions);
         if (appearingRoot.isDestroyed()) {
             listener.onError("Could not set root - appearingRoot is already destroyed");
             return;
         }
+        layoutDirectionApplier.apply(appearingRoot, defaultOptions);
         rootLayout.addView(appearingRoot.getView(), matchParentWithBehaviour(new BehaviourDelegate(appearingRoot)));
         Options options = appearingRoot.resolveCurrentOptions(defaultOptions);
         AnimationOptions enter = options.animations.setRoot.getEnter();
@@ -78,6 +78,8 @@ private void animateSetRootAndReportSuccess(ViewController root,
                     () -> {
                         if (!root.isDestroyed()) {
                             listener.onSuccess(root.getId());
+                        } else {
+                            listener.onError("Could not set root - root was destroyed before animation completed");
                         }
                         return Unit.INSTANCE;
                     });