Skip to content

'together' flag tabs loading webviews#8202

Merged
markdevocht merged 22 commits into
masterfrom
bugfix/TOGETHER-tabs-loading-webviews
Jan 14, 2026
Merged

'together' flag tabs loading webviews#8202
markdevocht merged 22 commits into
masterfrom
bugfix/TOGETHER-tabs-loading-webviews

Conversation

@markdevocht
Copy link
Copy Markdown
Contributor

The problem wasn't that the 'Together' flag didn't work, because it did, but that WKWebviews need special handling to load when not being presented.

@markdevocht markdevocht requested a review from noomorph January 12, 2026 14:07
Comment thread playground/src/screens/LayoutsScreen.tsx Outdated
Comment thread playground/src/screens/TabsTogetherTest.tsx Outdated
Comment thread playground/src/screens/LayoutsScreen.tsx Outdated
Comment thread ios/BottomTabsTogetherAttacher.mm
@markdevocht markdevocht requested a review from d4vidi January 12, 2026 15:30
Comment thread playground/src/screens/FirstBottomTabScreen.tsx Outdated
Comment thread playground/src/screens/TabsTogetherTest.tsx Outdated
Comment thread playground/src/screens/FirstBottomTabScreen.tsx Outdated
Comment thread playground/src/screens/FirstBottomTabScreen.tsx Outdated
Comment thread playground/src/screens/FirstBottomTabScreen.tsx Outdated
Comment thread playground/src/screens/TabsTogetherTest.tsx Outdated
@markdevocht markdevocht requested a review from d4vidi January 13, 2026 10:31
@markdevocht markdevocht enabled auto-merge (squash) January 14, 2026 12:07
Comment thread playground/src/screens/FirstBottomTabScreen.tsx
Comment thread playground/src/screens/FirstBottomTabScreen.tsx Outdated
Comment thread playground/src/screens/TabbedWebViewScreen.tsx Outdated
Comment thread playground/src/screens/TabbedWebViewScreen.tsx Outdated
Copy link
Copy Markdown
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely convinced the load order compared to a plain loaded count indicator has any added value but it's technically alright

@markdevocht markdevocht merged commit 28ba788 into master Jan 14, 2026
3 checks passed
@d4vidi d4vidi deleted the bugfix/TOGETHER-tabs-loading-webviews branch January 14, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RNN 'together' loading of tabs are not reloading webviews

2 participants