Badge - add BadgeDriver and scope inner testIDs#3993
Open
MIchaelZablianov wants to merge 4 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
Collaborator
Author
|
#rebuild |
adids1221
reviewed
May 20, 2026
| allowFontScaling={false} | ||
| numberOfLines={1} | ||
| testID="badge" | ||
| testID={testID ? `${testID}.label` : 'badge'} |
Contributor
There was a problem hiding this comment.
This could be a breaking change for users who relays on this testID for testing.
For now I would leave it as is.
adids1221
reviewed
May 20, 2026
| //@ts-ignore | ||
| borderColor={borderColor} | ||
| testID={testID ? `${testID}.icon` : undefined} | ||
| {...iconProps} |
Contributor
There was a problem hiding this comment.
Notice here that the iconProps will override the testID
adids1221
reviewed
May 20, 2026
| }); | ||
|
|
||
| it('should not render icon when icon prop is missing', () => { | ||
| const driver = getDriver({label: '5'}); |
Contributor
There was a problem hiding this comment.
do you need to pass label in this case ?
adids1221
reviewed
May 20, 2026
|
|
||
| it('should expose default badge size when no size prop is given', () => { | ||
| const driver = getDriver({label: '5'}); | ||
| expect(driver.getSize()).toEqual(20); |
Contributor
There was a problem hiding this comment.
if the default size is set in some constant maybe it's better to use it here.
I didn't checked it.
adids1221
reviewed
May 20, 2026
Contributor
adids1221
left a comment
adids1221
left a comment
There was a problem hiding this comment.
Nice work let few comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Badge - add
BadgeDriverand scope inner testIDs (${testID}.label,${testID}.icon)This PR:
BadgeDrivernext to the component (badge/badge.driver.ts), composinguseComponentDriver,usePressableDriver,TextDriver, andImageDriver. ExposesgetLabel,getIcon,getStyle,getSize.${testID}.label(falls back to the legacy"badge"when notestIDis provided, to preserve backward compatibility for any existing tests).${testID}.icon(only whentestIDis provided).BadgeDriverfromsrc/testkit/index.ts.badge.driver.spec.tsxcovering label text, icon presence, and size.This unblocks PR https://github.com/wix-private/wix-react-native-ui-lib/pull/6104 which needs to compose
BadgeDriverfrom the public testkit.Changelog
Badge - add
BadgeDriverand scope inner testIDs (${testID}.label,${testID}.icon)Additional info
https://wix.atlassian.net/browse/MADS-4754