fix: initialize base color scheme per instance#4013
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes stale theme state in
asBaseComponentby readingScheme.getSchemeType()for eachBaseComponentinstance instead of capturing a module-level value once at import time.This lets components mounted after a scheme change start with the active scheme, so switching back to the original scheme still changes their
state.colorSchemeand triggers the expected re-render.Fixes #3945.
This was implemented with Codex assistance, with the final one-line behavior change manually reviewed against the issue's repro path.
Changelog
asBaseComponentnow initializes color scheme state per instance, preventing stale theme colors after toggling between light and dark mode.Additional info
Verification:
corepack yarn eslint packages/react-native-ui-lib/src/commons/asBaseComponent.tsx -c .eslintrc.jscorepack yarn build:devgit diff --checkNotes:
tsc --noEmitwas not used because this repo'stsconfig.jsonsetsemitDeclarationOnly, which conflicts withnoEmit.git pushran the repo pre-push hook and failed before push because my local branch used the defaultcodex/prefix and repo-wide lint on this Windows checkout reports CRLF line endings in many untouched files. I renamed the branch tofix/base-color-schemeand pushed with--no-verify; the focused touched-file lint andbuild:devpass.