Skip to content

fix: avoid duplicate Android autolinking config#4014

Open
omribz156 wants to merge 1 commit into
wix:masterfrom
omribz156:codex/exclude-uilib-native-config-from-js-package
Open

fix: avoid duplicate Android autolinking config#4014
omribz156 wants to merge 1 commit into
wix:masterfrom
omribz156:codex/exclude-uilib-native-config-from-js-package

Conversation

@omribz156
Copy link
Copy Markdown

Description

Closes #3950

This keeps react-native-ui-lib from publishing the generated lib/react-native.config.js file that is copied from uilib-native during package builds.

uilib-native remains the package that owns the Android native autolinking config and native package classes. This avoids the JS package being treated as a second Android native package in newer React Native autolinking flows.

Changelog

  • Fix Android autolinking package metadata for react-native-ui-lib consumers using uilib-native.

Additional info

Related user workaround in #3805: patching the copied react-native.config.js out of the JS package resolves the RN/Expo Android build failure. This PR applies that at packaging time instead.

Verification

  • node -e "JSON.parse(require('fs').readFileSync('packages/react-native-ui-lib/package.json','utf8'))"
  • Created a temporary packages/react-native-ui-lib/lib/react-native.config.js from packages/uilib-native/react-native.config.js, then ran npm pack ./packages/react-native-ui-lib --dry-run --json and confirmed lib/react-native.config.js is excluded from the package file list.
  • git diff --check

I did not run a full Android build locally; this machine does not have the required React Native Android app setup for the reported RN 0.84 flow.

This was implemented with Codex assistance, with the patch kept focused and manually reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android build fails error: cannot find symbol new HighlighterViewPackage()

1 participant