fix: avoid duplicate Android autolinking config#4014
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3950
This keeps
react-native-ui-libfrom publishing the generatedlib/react-native.config.jsfile that is copied fromuilib-nativeduring package builds.uilib-nativeremains the package that owns the Android native autolinking config and native package classes. This avoids the JS package being treated as a second Android native package in newer React Native autolinking flows.Changelog
react-native-ui-libconsumers usinguilib-native.Additional info
Related user workaround in #3805: patching the copied
react-native.config.jsout of the JS package resolves the RN/Expo Android build failure. This PR applies that at packaging time instead.Verification
node -e "JSON.parse(require('fs').readFileSync('packages/react-native-ui-lib/package.json','utf8'))"packages/react-native-ui-lib/lib/react-native.config.jsfrompackages/uilib-native/react-native.config.js, then rannpm pack ./packages/react-native-ui-lib --dry-run --jsonand confirmedlib/react-native.config.jsis excluded from the package file list.git diff --checkI did not run a full Android build locally; this machine does not have the required React Native Android app setup for the reported RN 0.84 flow.
This was implemented with Codex assistance, with the patch kept focused and manually reviewed.