⚡ Optimize dict get inside decay phase loop

[wjohns989]

💡 What: Optimized dictionary .get() method lookups in _phase_decay loop in muninn/consolidation/daemon.py by caching the method references to local variables before the loop.
🎯 Why: To avoid repeated attribute lookups (LOAD_ATTR opcodes) during each iteration, improving performance by reducing constant overhead in a critical loop.
📊 Measured Improvement: In a standalone benchmark simulating the loop over 500 records run 10,000 times, execution time dropped from ~1.20s down to ~1.07s (a ~10.8% reduction in execution time for this block of logic).

---

PR created automatically by Jules for task 4154407427658409631 started by @wjohns989

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Code Review

This pull request refactors the _phase_decay method in the consolidation daemon to optimize map lookups by caching method references. Feedback suggests that direct dictionary access is preferable over .get() calls because the keys are guaranteed to exist, which would improve efficiency and simplify the implementation in accordance with the project's 'Optimal Reasoning' style guide.

[gemini-code-assist]

While caching the .get method reference is a common Python micro-optimization, it is redundant here because the centrality_map and utility_map are guaranteed to contain all keys from record_ids (as implemented in the batch fetch calls on lines 202-203). Using direct dictionary access centrality_map[rid] is more efficient than c_get(rid, 0.0) as it avoids the function call overhead and the internal logic for handling default values. This also simplifies the code by removing the need for intermediate method reference variables.

        for record in records:
            rid = record.id

            # Recalculate importance
            new_importance = calculate_importance(
                record,
                max_similarity=0.0, # Would need vector lookup — simplified for now
                centrality=centrality_map[rid],
                retrieval_utility=utility_map[rid],
            )

References

1. Optimal Reasoning: Question every assumption. The assumption that .get() with a default is necessary is incorrect here because the maps are pre-populated with all relevant keys during the batch-fetching phase. ^(link)