sql statefulsets: remove cpu limits#2050
Merged
Merged
Conversation
tarrow
approved these changes
Apr 7, 2025
Contributor
|
I guess there are probably more of these null limits out there waiting to bite us |
Contributor
|
Yes - I already tried to clean this up and then had to revert it. I believe related to the helmfile->argo values issues. We could probably just try to revert the revert again. See: #1842 |
Contributor
Author
|
ah.. well since you approved I merged it for now in order to make #2048 work (which I merged before and then was wondering why the staging workloads are down again :P) but yeah I think we're now set up to get this same surprise for the other statefulsets as well |
Contributor
Author
|
follow up #2057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: https://phabricator.wikimedia.org/T390823
Currently SQL StatefulSets can not come back up due to invalid cpu limits