Use pull_request_target for mattermost.yml#2713
Open
addshore wants to merge 1 commit into
Open
Conversation
workflow runs from the target/base branch (your main), and has access to repo secrets. However user provided PRs can thus not change the workflow code that is running, unless your repo is already compromised
outdooracorn
reviewed
May 3, 2026
Member
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
So what does this PR do? Please state that in the PR description.
| pull_request_target: | ||
| types: [ opened, reopened ] | ||
|
|
||
| permissions: {} |
Contributor
Author
addshore
commented
May 3, 2026
| runs-on: ubuntu-latest | ||
| if: ${{ github.actor != 'dependabot[bot]' }} | ||
| steps: | ||
| - uses: mattermost/action-mattermost-notify@2.0.0 |
Contributor
Author
There was a problem hiding this comment.
Arguably another improvement would either be pinning this image, OR just not using the image and calling the webhook directly.
As this action is technically unpinned external code (however this was a problem that already existed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the workflow run from the target/base branch instead of PR source branch so that it has access to repo secrets 1.
User provided PRs can not change the workflow code that is running, unless the repo is already compromised.