shellcheck: add yaml helper script#2743
Draft
deer-wmde wants to merge 7 commits into
Draft
Conversation
Contributor
Author
|
Today I tried if this would work with shfmt too - it does in theory, but in practice would make them even more unreadable while looking at the YAML This means currently the CI workflow #2740 would kinda need a messy order to run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since shellcheck does not parse the embedded shell scripts we have in our k8s job yaml files, I tried to see if they can be reliably extracted via
yq, in order to lint them. This PR contains a script that extracts them in a git-ignored directory. I tried running this in CI on this repo fork here: https://github.com/deer-wmde/debug-wbaas-deploy/actions/runs/25557616246/job/75020526364 (sadly the output in this example run is bloated by all the other recommendations for "real" scripts, too)weak points:
shell -c commandStill I think this could be handy to have, as errors in these scripts are especially tricky.
https://phabricator.wikimedia.org/T302394
Bug: T302394