Skip to content

Fix empty data-src attribute #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xsonic wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix empty data-src attribute #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3249264
Fix for empty data-src attribute and continue loop
xsonic Jan 31, 2019
4b3c637
Change var to let on ES6 file
xsonic Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions toad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@

for (; j < len; ++j) {
this_el = elements[j];
if (!this_el.getAttribute('data-src') || !isInViewport(this_el.getBoundingClientRect())) {
return;

if (!this_el.getAttribute('data-src') || this_el.getAttribute('data-src') === '' || !isInViewport(this_el.getBoundingClientRect())) {
continue;
}

if (!!this_el.getAttribute('data-src') && isInViewport(this_el.getBoundingClientRect())) {
Expand Down
8 changes: 4 additions & 4 deletions toad.next.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
}

function rebounce (f) {
var scheduled, context, args, i, j;
let scheduled, context, args, i, j;

return function () {
context = this;
args = [];
Expand Down Expand Up @@ -44,8 +44,8 @@
for (;j < i; ++j) {
let this_el = elements[j];

if (!this_el.getAttribute('data-src') || !isInViewport(this_el.getBoundingClientRect())) {
return;
if (!this_el.getAttribute('data-src') || this_el.getAttribute('data-src') === '' || !isInViewport(this_el.getBoundingClientRect())) {
continue;
}

if (!!this_el.getAttribute('data-src') && isInViewport(this_el.getBoundingClientRect())) {
Expand Down