Fix logic error in chooseResume method#100
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
…ty list check Replace the always-false condition 'type(len(resumes)) != int' with the correct check 'len(resumes) == 0' to properly detect when no resumes are available. The type() check was a logic anti-pattern that would never trigger the error message, preventing proper feedback when no resumes are found. Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a logic error in the
chooseResumemethod inlinkedin.pywhere an always-false condition was preventing proper error handling.Changes
linkedin.py(line 311)type(len(resumes)) != intwas always False becauselen()always returns an integerlen(resumes) == 0to properly detect when no resumes are availableImpact
This fix ensures that users receive the error message when no resumes are found in their LinkedIn account, instead of silently failing to select a resume.