Fix company blacklist matching to use jobDetail instead of jobTitle#104
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Fix company blacklist matching to use jobDetail instead of jobTitle#104cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
The blacklistCompanies filter should match against the job detail text where company information is located, not the job title. This ensures companies in the blacklist are properly detected and flagged. Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed a bug in the company blacklist filtering logic where the filter was checking against
jobTitleinstead ofjobDetail.Change Details
linkedin.py(line 335)jobTitle.lower()tojobDetail.lower()Why This Matters
The
config.blacklistCompanieslist contains company names that should not be applied for. These company names appear in the job detail section, not in the job title. By matching againstjobTitle, the blacklist was ineffective and blacklisted companies were not being properly filtered out.Now the blacklist correctly matches against the job detail text where company information is actually located.
Testing
This is a single-line fix that corrects the logic to match the intended behavior. The change is minimal and focused on making the company blacklist feature work as intended.