Improve code quality: fix type check bug and add type hints#89
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Improve code quality: fix type check bug and add type hints#89cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
cursor
Bot
commented
Mar 19, 2026
cursor
Bot
commented
- Fix incorrect type check in linkedin.py: replace 'type(len(resumes)) != int' with 'len(resumes) == 0' (len() always returns int, so the original check would never evaluate to true)
- Add return type hints to utility functions (prRed, prGreen, prYellow, writeResults, printInfoMes)
- Add return type hint to chromeBrowserOptions function
- Improve code formatting for PEP 8 compliance in jobsToPages and writeResults functions
- Fix incorrect type check in linkedin.py line 312: replace 'type(len(resumes)) != int' with 'len(resumes) == 0' (len() always returns int) - Add return type hints to utility functions in utils.py (prRed, prGreen, prYellow, writeResults, printInfoMes) - Add return type hint to chromeBrowserOptions function - Import Options from selenium.webdriver.chrome.options for proper type annotation - Fix code formatting and spacing for PEP 8 compliance in jobsToPages and writeResults functions Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.