Skip to content

Commit 296f770

Browse files
committed
Refactor onChangeExternal method
1 parent f84b090 commit 296f770

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

src/DateInput.tsx

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -460,11 +460,17 @@ export default function DateInput({
460460
: Number((formElement as unknown as HTMLInputElement).value);
461461
});
462462

463-
if (formElements.every((formElement) => !formElement.value)) {
463+
const isEveryValueEmpty = formElements.every((formElement) => !formElement.value);
464+
465+
if (isEveryValueEmpty) {
464466
onChangeProps(null, false);
465-
} else if (
466-
formElements.every((formElement) => formElement.value && formElement.validity.valid)
467-
) {
467+
return;
468+
}
469+
470+
const isEveryValueFilled = formElements.every((formElement) => formElement.value);
471+
const isEveryValueValid = formElements.every((formElement) => formElement.validity.valid);
472+
473+
if (isEveryValueFilled && isEveryValueValid) {
468474
const year = Number(values.year || new Date().getFullYear());
469475
const monthIndex = Number(values.month || 1) - 1;
470476
const day = Number(values.day || 1);
@@ -475,6 +481,7 @@ export default function DateInput({
475481

476482
const processedValue = getProcessedValue(proposedValue);
477483
onChangeProps(processedValue, false);
484+
return;
478485
}
479486
}
480487

0 commit comments

Comments
 (0)