Add support for firstInputRef#625
Open
frederickf wants to merge 1 commit into
Open
Conversation
|
I also need this, for the exact same reason. Adding a label and wish to focus the input when clicking the label. |
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
c1a58a8 to
84b1863
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
37e50fb to
5584926
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
1fd7f2d to
daa2c24
Compare
|
is there any plan to merge this PR? |
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
cf15ab3 to
a602a19
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
4e7cb80 to
4575a91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a result of the discussion at #622
In Input.tsx and MonthSelect.tsx I had to update inputRef to be typed with MutableRefObject because later I assign the referenced element in a ref callback.
I hope it is okay that I updated Test.tsx to demonstrate how it works. There wasn't much room in the README for an example.
In Test.tsx I originally used a label element, but that triggered some accessibility warnings related not using the
forattribute. I tried using div and got accessibility warnings about using an onClick on a non-interactive element. I ultimately used a button, styled to look like a label. Normally a label would communicate the purpose of the input, but I think a button will be fine because the underlying inputs all support the appropriate aria labels identifying their purpose.