Fix Worker was terminated error on unmount#1877
Merged
wojtekmaj merged 3 commits intoSep 18, 2024
Merged
Conversation
wojtekmaj
approved these changes
Sep 18, 2024
Owner
|
Thanks mate! |
andriivitiv
deleted the
fix-error-on-unmount-if-loading-has-not-finished-yet
branch
4 tasks
16 tasks
QichenZhu
reviewed
Apr 13, 2026
|
|
||
| return () => { | ||
| loadingTask.destroy(); | ||
| loadingPromise.finally(() => loadingTask.destroy()); |
There was a problem hiding this comment.
This change introduced a race condition when quickly switching to a new PDF file. The cleanup could run asynchronously after the new PDF started loading and cause a crash.
It's now fixed with PRs mozilla/pdf.js#20503, Expensify/react-fast-pdf#51, Expensify/react-fast-pdf#52, and Expensify/App#80160.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1062 -
Worker was terminatederror on document unmount if loading has not yet finished.