Fix EnumPostProcessor#136
Open
wol-soft wants to merge 1 commit into
Open
Conversation
…validators When a property declared both "type": "string" (or "type": "integer") and "enum", the EnumPostProcessor only removed the EnumValidator but left the TypeCheckValidator (is_string/is_int check) in place. Passing a valid enum instance to the setter then incorrectly triggered that type check and threw InvalidTypeException. Fix: also strip TypeCheckInterface validators when the enum post-processor takes over a property, since the enum filter handles conversion and the UnitEnum guard covers type safety. Fixes #129 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 26374991150Coverage increased (+0.001%) to 98.555%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix EnumPostProcessor stripping type-check validators alongside enum validators
When a property declared both "type": "string" (or "type": "integer") and "enum", the EnumPostProcessor only removed the EnumValidator but left the TypeCheckValidator (is_string/is_int check) in place. Passing a valid enum instance to the setter then incorrectly triggered that type check and threw InvalidTypeException.
Fix: also strip TypeCheckInterface validators when the enum post-processor takes over a property, since the enum filter handles conversion and the UnitEnum guard covers type safety.
Fixes #129