Phase 1 cleanup: drop debug-era artifacts and Phase labels

  - include/wolfboot/wcs_wolfhsm.h: remove WCS_WOLFHSM_MAX_REQ_SIZE /
    MAX_RSP_SIZE macros that hardcoded 1288U; the value is just WH_COMM_MTU
    and silently desyncs if WOLFHSM_CFG_COMM_DATA_LEN changes
  - src/wolfhsm_callable.c: use WH_COMM_MTU directly in size guards;
    replace bare 56 server_id with WCS_WOLFHSM_SERVER_ID; drop Phase 1b /
    Phase 3 comment, keep only the real-HW pageSize=8 invariant
  - test-app/wcs/wolfhsm_test.c: drop unused wolfboot/wcs_wolfhsm.h
    include; reword the Phase 1c exerciser header to a stable description

  m33mu still green (CommInit + RNG round-trip + BKPT 0x7f).

Author: aidangarske

include/wolfboot/wcs_wolfhsm.h

@@ -13,15 +13,6 @@
 
 #ifdef WOLFCRYPT_TZ_WOLFHSM
 
-/* Match wolfHSM's WH_COMM_MTU; bridge buffers are sized to this. */
-#ifndef WCS_WOLFHSM_MAX_REQ_SIZE
-#define WCS_WOLFHSM_MAX_REQ_SIZE 1288U
-#endif
-
-#ifndef WCS_WOLFHSM_MAX_RSP_SIZE
-#define WCS_WOLFHSM_MAX_RSP_SIZE 1288U
-#endif
-
 int CSME_NSE_API wcs_wolfhsm_transmit(const uint8_t *cmd, uint32_t cmdSz,
         uint8_t *rsp, uint32_t *rspSz);
 

src/wolfhsm_callable.c

@@ -36,15 +36,15 @@ void *_sbrk(unsigned int incr)
         (uint32_t)(&_heap_size));
 }
 
-/* Phase 1b uses a 32 KiB ramsim partition pair for the NVM backend; Phase 3
- * swaps this for a flash-backed adapter over wolfBoot's hal_flash_*.
- * pageSize must match WHFU_BYTES_PER_UNIT (8) — wolfHSM programs the flash
+/* pageSize must match WHFU_BYTES_PER_UNIT (8) — wolfHSM programs the flash
  * one unit at a time, so a larger pageSize causes the modulo check in
  * whFlashRamsim_Program to fail. */
 #define WCS_WOLFHSM_RAMSIM_SIZE      (32U * 1024U)
 #define WCS_WOLFHSM_RAMSIM_SECTOR    (8U * 1024U)
 #define WCS_WOLFHSM_RAMSIM_PAGE      8U
 
+#define WCS_WOLFHSM_SERVER_ID        56U
+
 static uint8_t                   g_ramsim_buf[WCS_WOLFHSM_RAMSIM_SIZE];
 static whFlashRamsimCtx          g_ramsim_ctx;
 static whFlashRamsimCfg          g_ramsim_cfg = {
@@ -78,7 +78,7 @@ static whCommServerConfig        g_comm_cfg = {
     .transport_context = &g_srv_tx_ctx,
     .transport_cb      = &whTransportNscServer_Cb,
     .transport_config  = &g_srv_tx_cfg,
-    .server_id         = 56, /* server identifier; NS client uses client_id=1 */
+    .server_id         = WCS_WOLFHSM_SERVER_ID,
 };
 static whServerConfig            g_server_cfg = {
     .comm_config = &g_comm_cfg,
@@ -129,10 +129,10 @@ int CSME_NSE_API wcs_wolfhsm_transmit(const uint8_t *cmd, uint32_t cmdSz,
      * only this local copy. The NS caller cannot mutate it under us. */
     rsp_capacity = *rspSz;
 
-    if (cmdSz == 0U || cmdSz > WCS_WOLFHSM_MAX_REQ_SIZE) {
+    if (cmdSz == 0U || cmdSz > WH_COMM_MTU) {
         return WH_ERROR_BADARGS;
     }
-    if (rsp_capacity == 0U || rsp_capacity > WCS_WOLFHSM_MAX_RSP_SIZE) {
+    if (rsp_capacity == 0U || rsp_capacity > WH_COMM_MTU) {
         return WH_ERROR_BADARGS;
     }
     if (!g_wolfhsm_ready) {

test-app/wcs/wolfhsm_test.c

@@ -11,8 +11,6 @@
 #include <stdio.h>
 #include <string.h>
 
-#include "wolfboot/wcs_wolfhsm.h"
-
 #include "wolfhsm/wh_client.h"
 #include "wolfhsm/wh_comm.h"
 #include "wolfhsm/wh_error.h"
@@ -59,11 +57,9 @@ static int wolfhsm_test_rng(void)
     return 0;
 }
 
-/*
- * Phase 1c exerciser. Initializes the wolfHSM client (which auto-registers
- * the wolfCrypt cryptocb under WH_DEV_ID), runs the CommInit handshake, then
- * exercises a real crypto op (RNG) routed through the secure-side server.
- */
+/* Initializes the wolfHSM client (auto-registers the wolfCrypt cryptocb
+ * under WH_DEV_ID), runs the CommInit handshake, exercises one crypto
+ * round-trip (RNG) through the secure-side server. */
 int cmd_wolfhsm_test(const char *args)
 {
     static const whTransportNscClientConfig nsc_cfg = { 0 };