Address copilot pr comments.

Author: twcook86

docs/Targets.md

@@ -1811,7 +1811,6 @@ Booting version: 0x1
 lpc55s69 init
     boot:   ver=0x1 state=0xFF
     update: ver=0x0 state=0xFF
-Hello from firmware version 1
 Calling wolfBoot_success()
     boot:   ver=0x1 state=0x00
     update: ver=0x0 state=0xFF
@@ -1843,7 +1842,6 @@ Booting version: 0x1
 lpc55s69 init
     boot:   ver=0x1 state=0x00
     update: ver=0x2 state=0xFF
-Hello from firmware version 1
 Update detected, version: 0x2
 Triggering update...
     boot:   ver=0x1 state=0x00
@@ -2021,7 +2019,6 @@ Booting version: 0x2
 lpc55s69 init
     boot:   ver=0x2 state=0x10
     update: ver=0x1 state=0xFF
-Hello from firmware version 2
 Calling wolfBoot_success()
     boot:   ver=0x2 state=0x00
     update: ver=0x1 state=0xFF

hal/lpc55s69-ns.ld

@@ -1,6 +1,6 @@
 MEMORY
 {
-    FLASH (rx) : ORIGIN = 0x00000000, LENGTH = @BOOTLOADER_PARTITION_SIZE@
+    FLASH (rx) : ORIGIN = 0x00000000, LENGTH = @WOLFBOOT_PARTITION_BOOT_ADDRESS@
     RAM (rwx)  : ORIGIN = 0x20000000, LENGTH = 32K
 }
 

hal/lpc55s69.c

@@ -84,11 +84,10 @@ void hal_init(void)
 //    BOARD_BootClockPLL150M();
 #ifdef DEBUG_UART
     uart_init();
+    uart_write("lpc55s69 init\n", 14);
 #endif
 #endif
 
-    uart_write("lpc55s69 init\n", 14);
-
 #if defined(__WOLFBOOT) || !defined(TZEN)
     memset(&pflash, 0, sizeof(pflash));
     FLASH_Init(&pflash);
@@ -195,6 +194,7 @@ int hal_trng_get_entropy(unsigned char *out, unsigned int len)
 #define IOCON_PIO_OPENDRAIN_DI 0x00u  /*!<@brief Open drain is disabled */
 #define IOCON_PIO_SLEW_STANDARD 0x00u /*!<@brief Standard mode, output slew rate control is enabled */
 
+#ifdef DEBUG_UART
 void uart_init(void)
 {
     CLOCK_EnableClock(kCLOCK_Iocon);
@@ -262,3 +262,4 @@ void uart_write(const char *buf, unsigned int sz)
         sz -= line_sz + 1U;
     }
 }
+#endif

include/wolfboot/wolfboot.h

@@ -477,7 +477,7 @@ extern "C" {
 #define IMG_STATE_NEW       0x00
 #define IMG_STATE_UPDATING  0x8F
 #define IMG_STATE_TESTING   0xEF
-#define IMG_STATE_FINAL_FLAGS 0xCF
+#define IMG_STATE_FINAL_FLAGS 0xBF
 #define IMG_STATE_SUCCESS   0xFF
 #define FLASH_BYTE_ERASED   0x00
 #define FLASH_WORD_ERASED   0x00000000UL

test-app/app_lpc55s69.c

@@ -110,17 +110,16 @@ void main(void)
 
     check_parts(&boot_ver, &update_ver, &boot_state, &update_state);
 
-    wolfBoot_printf("Hello from firmware version %d\n", boot_ver);
-
     if (
         boot_ver != 0 &&
         (boot_state == IMG_STATE_TESTING || boot_state == IMG_STATE_NEW)
     )
     {
-        wolfBoot_printf("Calling wolfBoot_success()\n");
 #ifdef WOLFCRYPT_SECURE_MODE
+        wolfBoot_printf("Calling wolfBoot_nsc_success()\n");
         wolfBoot_nsc_success();
 #else
+        wolfBoot_printf("Calling wolfBoot_success()\n");
         wolfBoot_success();
 #endif
         check_parts(&boot_ver, &update_ver, &boot_state, &update_state);